fix(subagents): keep print-host parents from settling without wait - #515
Open
tt-a1i wants to merge 2 commits into
Open
fix(subagents): keep print-host parents from settling without wait#515tt-a1i wants to merge 2 commits into
tt-a1i wants to merge 2 commits into
Conversation
--print/--json cannot re-invoke after agent_settled, so spawn text that tells the model to end the turn drops required child results. Require subagent_wait on non-TUI hosts and send a bounded follow-up barrier.
github-actions
Bot
added
documentation
Correct E-06..10 as pre-fix, point at bun/unit logs and hang issue #516, and keep the reliability notes from being read as a Benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--print/--mode jsoncannot re-invoke the parent afteragent_settled. Stock spawn text still tells the model it may end the turn; required child results are lost (E high-fast 3/10 print-settle failures).subagent_wait, plus a boundedfollowUp+triggerTurnbarrier if the parent settles while direct children are running. Interactive TUI guidance is unchanged.cursor-grok-4.6-high-fast: 7/10 before (v0.8.1 stock) → 10/10 after. Isolatedbun run checkandbun run testpass. Closes nothing; tracks bug(subagents): --print/--json parent can settle while required children are still running [under investigation] #512. Do not merge from this reliability session unless a maintainer asks.Test plan
tests/extensions/subagents/print-host.test.tsand prompt contractbun run check&&bun run testin isolated v0.8.1 worktree