Re:PR#58 - Add STACAS as new method component - #85
Merged
Conversation
Co-authored-by: Michaela Müller <51025211+mumichae@users.noreply.github.com>
…ontainer baser_r:1 Co-authored-by: Luke Zappia <lazappi@users.noreply.github.com>
8 tasks
Contributor
Author
|
Hi, just checking in on this PR. Let me know if there’s anything I should update or clarify to help move it forward. Thanks! |
rcannood
approved these changes
Aug 12, 2026
rcannood
left a comment
rcannood
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you @JGarnica22 !
rcannood
added a commit
that referenced
this pull request
Aug 12, 2026
* add method STACAS * add method STACAS * updata changelog * Update: base_r container Co-authored-by: Michaela Müller <51025211+mumichae@users.noreply.github.com> * Update: STACAS installation with depedencies, compatible with new R container baser_r:1 Co-authored-by: Luke Zappia <lazappi@users.noreply.github.com> * fix: move STACAS comment below the kBET on New functionality section * fix: remove boilerplate comments for better readability * add: method_types configuration * fix: do not load unneeded counts, and specificy anchor.features --------- Co-authored-by: Josep Garnica <JGarnica22@users.noreply.github.com> Co-authored-by: Michaela Müller <51025211+mumichae@users.noreply.github.com> Co-authored-by: Luke Zappia <lazappi@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add some minor changes on STACAS method previously added in PR #58
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!