Skip to content

Scgpt update - #87

Open
jkobject wants to merge 27 commits into
openproblems-bio:mainfrom
jkobject:scgpt_update
Open

Scgpt update#87
jkobject wants to merge 27 commits into
openproblems-bio:mainfrom
jkobject:scgpt_update

Conversation

@jkobject

Copy link
Copy Markdown
Contributor

Describe your changes

moving this to a new PR

@rcannood rcannood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

Comment thread src/methods/scgpt_zeroshot/config.vsh.yaml Outdated
Comment thread src/methods/scprint/config.vsh.yaml
@jkobject

Copy link
Copy Markdown
Contributor Author

Independent supersession review

Reviewed exact stale head 10dfe3c2be683b8baed63fbcdc1368317152c47d read-only against current main 68eb2ecc52990617dbb6d1bb5c7158d9893796bb and retained #95 exact head ebc7bf2b8d0fa3ef54d75f4946629aa06dfcb1bf.

Both review threads have substantive answers and are resolved. The current tree delta from main to this stale head contains only:

  • invalid removal of the required scGPT setup: structure/comment blocks (8 and 9 deleted lines), and
  • a scPRINT comment-indentation-only change.

The historical scPRINT max_len change is already on main via #86. The retained #95 carries the valid remaining scPRINT checkpoint-name update as a clean two-file diff and has fresh exact-head green CI. Therefore closing #87 as superseded would discard no unique valid functionality.

Recommended non-destructive close comment (maintainer/author may close; this reviewer did not):

Superseded by current main plus #95. The scPRINT max_len update from this branch was already merged in #86; #95 retains the checkpoint-name update on current main with fresh green CI. The two scGPT deletions remaining in this stale PR are intentionally excluded because they remove required configuration structure. Both review threads are answered and resolved. Closing without merge; no unique valid functionality is discarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants