Fix broken paths in the helper scripts - #22
Open
rcannood wants to merge 1 commit into
Open
Conversation
* Point test_resources.sh at simple_mlp_train/ and novel_train/ * Drop the stale predict_modality/ prefix from the -main-script paths * Separate rename_keys with ; rather than , -- viash's multiple_sep is ;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Three helper scripts can't run as written. None of them is exercised by CI, so the breakage went unnoticed -- but it blocks regenerating the test resources and running either workflow locally.
scripts/create_datasets/test_resources.shinvokessrc/methods/simple_mlp/train/config.vsh.yamlandsrc/methods/novel/train/config.vsh.yaml; the components actually live insimple_mlp/simple_mlp_train/andnovel/novel_train/.run_test.shscripts point attarget/nextflow/predict_modality/workflows/..., a leftover from the openproblems-v2 monorepo. Viash builds totarget/nextflow/<namespace>/<name>, i.e.target/nextflow/workflows/...-- whichscripts/create_datasets/resources.shalready gets right.src/workflows/run_benchmark/run_test.shseparatesrename_keyswith commas, but viash declaresmultiple_sep: ";"for that argument (workflowHelper.nf#L1563), so the whole thing arrives as one string and trips thesplit(":")assertion on line 1610.Also refreshed a stale comment in
process_datasets/run_test.shthat told you to runbin/viash_build -q 'batch_integration'.First of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!