Fix obsm key in cellmapper_scvi - #23
Open
rcannood wants to merge 1 commit into
Open
Conversation
cellmapper's map_obsm() writes f"{key}{prediction_postfix}", so
map_obsm(key="mod2", prediction_postfix="pred") produces "mod2pred",
not "mod2_pred" -- as cellmapper_linear already had it right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
cellmapper_scvicrashes on every single run, right at the end -- after it has trained scVI/PoissonVI on a GPU.CellMapper.map_obsm()writes its result tof"{key}{prediction_postfix}":So
map_obsm(key="mod2", prediction_postfix="pred")producesobsm["mod2pred"], but the script readsobsm["mod2_pred"]->KeyError. Its siblingcellmapper_linearalready reads the right key; only the scvi variant drifted.Worth flagging that this was invisible in the last run:
labels_tw.configsetserrorStrategy = 'ignore'after three attempts, so a method that reliably crashes shows up as missing rows inscores.yamlrather than as a failure. Might be worth a separate look at how we surface "crashed" vs "no score".Part of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!