Make mse work for dense predictions - #26
Open
rcannood wants to merge 1 commit into
Open
Conversation
sparse - dense yields a np.matrix, which has no .power(), so a method returning a dense normalized layer crashed the metric rather than scoring poorly. Coerce both layers to csr first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
file_prediction.yamlasks for adoublenormalizedlayer -- it says nothing about sparsity. Every method we ship happens to write acsc_matrix, so this has never bitten, but a method returning a dense array crashes the metric:sparse - ndarrayyields anp.matrix, which has no.power(). A contributor hitting this gets a crashed metric instead of a poor score, which is the wrong failure mode -- especially witherrorStrategy = 'ignore'turning it into a silently missing row.Coercing both layers to CSR first. Scores are unchanged for the sparse case:
Part of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!