Declare normalization_id on file_test_mod2 - #30
Open
rcannood wants to merge 1 commit into
Open
Conversation
run_benchmark reads dataset_uns_mod2.normalization_id off this file to route methods to the right dataset, but only file_test_mod1 declared it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
run_benchmark/main.nfextracts metadata from--input_test_mod2and then does:rna_normdecides which methods run on which dataset (thepreferred_normalizationfilter), so in theswapdirection the whole routing hangs offnormalization_idintest_mod2.file_test_mod1.yamldeclares that slot;file_test_mod2.yamlnever did. It works today only becauseprocess_datasethappens to copy it onto both objects.One-slot change to write down what we already depend on.
Part of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!