Stop reserving 30 CPUs for a single-threaded lm - #42
Merged
Conversation
n_cores was computed and never used, and pblapply() runs serially without a cl argument, so highcpu was reserving 30 cores to use one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
lmasks forhighcpu(30 cores) but runs on one. The per-gene loop iswith no
clargument, so it's serial. And the one thing that looks like it was meant to enable parallelism:is computed at the top of the script and never referenced again.
Dropped the dead line and moved the label to
lowcpu. Kepthighmem/hightime-- the memory and runtime asks are real, it's only the CPU reservation that was fictional.Happy to go the other way and pass
cl = n_coresinstead if we'd rather have the speedup; that's a bigger change though, sincepblapplywith a fork cluster would copydr_train/X_mod2per worker.Part of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!