Tidy up the two workflow method configs - #44
Merged
Conversation
* novel merges wf_method.yaml, like simple_mlp already does * drop the stale input_transform key from simple_mlp's predict call
rcannood
force-pushed
the
chore/workflow-method-config-hygiene
branch
from
July 29, 2026 13:32
1c6efeb to
2ce6343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Two small inconsistencies between our two multi-component methods.
novelmerges the wrong api spec.simple_mlpmergeswf_method.yaml, which exists precisely for "workflows that combine multiple components";novelmergescomp_method.yaml. The practical difference is thatcomp_method.yamlpulls inrun_and_check_output.pyand the test resource directory, neither of which means anything for a component with only anextflowrunner and no script of its own.simple_mlppasses a key that doesn't exist.input_transformis not an argument ofsimple_mlp_predict(nor ofcomp_method_predict.yaml) and is never put in the state._processFromStatesilently drops keys that aren't required inputs, so it's been harmless -- but it reads like something is being threaded through when nothing is.After the change
novelresolves totest_resources: ['check_config.py']and keeps the label added in #37.Part of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!