Make the test fixture non-square - #51
Open
rcannood wants to merge 1 commit into
Open
Conversation
The common test datasets are 134 x 134 and 1500 x 1500, so a component can confuse n_vars(mod1) with n_vars(mod2) and viash test still passes. No real dataset looks like that. Trim mod1 after processing, before the models get pre-trained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Three of the bugs in this review series were invisible to CI for the same reason: in
resources_testthe two modalities have identical widths.No real dataset looks like that -- bmmc_cite is 13953 GEX features against 134 ADT proteins. So a component can use
n_vars(mod1)where it meansn_vars(mod2)andviash testgoes green, then it dies on the first full run. That's exactly what #24 was.Adding a
trim_mod1_features.pystep totest_resources.shthat drops a quarter of mod1's features afterprocess_datasetsand before the models are pre-trained (the ordering matters -- the storednovelandsimple_mlpcheckpoints are sized from mod1, so they have to be trained against the trimmed version).Trimmed files still satisfy
file_train_mod1.yaml-- subsetting onvarkeeps every required slot:I did look at fixing this in the common fixture instead, which would be the more principled place -- but
resources_test/common/openproblems_neurips2021is shared with other tasks, so making it asymmetric for our benefit isn't ours to do. Doing it task-side keeps the blast radius here.To take effect
This PR only changes the generation script; the resources on S3 are still square. Regenerating and syncing writes to the shared bucket, so I've left that to you:
bash scripts/create_datasets/test_resources.sh # regenerates + prints a dryrun sync aws s3 sync --profile op \ resources_test/task_predict_modality \ s3://openproblems-data/resources_test/task_predict_modality \ --delete(the script's own sync still has
--dryrunon it, deliberately.)Part of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!