Give file_pretrained_model an example - #52
Closed
rcannood wants to merge 1 commit into
Closed
Conversation
run_and_check_output only assigns a value to an argument when the file spec has a default or an example, so --output was silently left off the command line and novel_train/simple_mlp_train failed on a missing required argument.
8 tasks
Member
Author
|
these examples should be set in the predict methods under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
novel_trainandsimple_mlp_traincannot passviash testonmain, and haven't been able to for a while:get_argument_sets()only gives an argument a value when the spec has adefaultor anexample:file_pretrained_model.yamlwas the only file spec with neither, so--outputnever made it onto the command line:With an example added:
For an output argument only the extension is read off the example, so a directory-shaped path gives the right thing (the pretrained model is a directory). The predict components already override
--input_modelthroughinfo.test_setup, so they're unaffected either way.Worth knowing: this is why #46 is red, and #33 was red for the same reason before it was merged. CI only tests components a PR touches, so it only shows up when someone edits
novel_trainorsimple_mlp_train-- and then it looks like that PR broke something.Part of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!