Say what the ks metrics actually compute - #27
Merged
Conversation
All 31 of these describe themselves as "The Kolmogorov-Smirnov statistic", but both components call `ks::kde.test()`, which is a kernel density based global two-sample comparison test -- a different thing that happens to live in a package called ks. The referenced doi (Duong's kernel smoothing book) was right all along. Left the metric ids alone so the results stay comparable across runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 31 metric descriptions across the two components describe themselves as "The Kolmogorov-Smirnov statistic", but both call
ks::kde.test(), which is a kernel density based global two-sample comparison test -- a different thing that happens to live in a package calledks. The referenced doi (Duong's kernel smoothing book) was right all along.Metric ids are left alone, so results stay comparable across runs.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!