Add rrsync sidecar docker image - #315
Open
mwestphall wants to merge 1 commit into
Open
Conversation
matyasselmeci
approved these changes
Jul 28, 2026
matyasselmeci
left a comment
matyasselmeci
left a comment
Contributor
There was a problem hiding this comment.
A few tweaks but overall fine. Pre-approving.
|
|
||
| RUN mkdir /data | ||
|
|
||
| RUN mkdir -p -m0755 /run/sshd && \ |
Contributor
There was a problem hiding this comment.
You might need to create /run/sshd in the entryping, since /run can be a tmpfs.
Comment on lines
+20
to
+23
| docker run --detach --name rsync-ssh \ | ||
| -v ~/authorized_keys:/root/.ssh/authorized_keys \ | ||
| -v ~/mydata:/data \ | ||
| -p2222:22 rsync-ssh |
Contributor
There was a problem hiding this comment.
Suggested change
| docker run --detach --name rsync-ssh \ | |
| -v ~/authorized_keys:/root/.ssh/authorized_keys \ | |
| -v ~/mydata:/data \ | |
| -p2222:22 rsync-ssh | |
| docker run --detach --name rrsync \ | |
| -v ~/authorized_keys:/root/.ssh/authorized_keys \ | |
| -v ~/mydata:/data \ | |
| -p2222:22 rrsync |
Also, maybe bind-mount /etc/ssh/keys so they're persisted between runs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new container to
contribthat runs sshd and rrsync to allow rsync-over-ssh, but no shell access, to a bind-mounted volume. Intended to run as a sidecar to another container.