OPNET-787: Add BGP_VIP_MANAGEMENT one-click knob - #1939
Merged
openshift-merge-bot[bot] merged 1 commit intoJul 31, 2026
Merged
Conversation
When set, render platform.baremetal.bgpVIPConfig into the generated install-config so the cluster advertises its API/ingress VIPs over BGP (enhancement 1982, DevPreview) instead of managing them with keepalived. The local/peer ASNs and the peer address default to the ENABLE_BGP_TOR speaker's configuration (BGP_CLUSTER_ASN/BGP_TOR_ASN, ToR address on the external subnet), overridable via BGP_VIP_PEER_ADDRESS. Deploy validation fails fast when the knob is set without ENABLE_BGP_TOR (nothing to peer with) or without a FEATURE_SET that enables the BGPBasedVIPManagement gate. Assisted-By: Claude Fable 5 Signed-off-by: Mat Kowalski <mko@redhat.com>
|
@mkowalski: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
mkowalski
added a commit
to mkowalski/openshift-release
that referenced
this pull request
Jul 31, 2026
New baremetalds-e2e-bgp-vip workflow: dev-scripts baremetal IPI install with BGP_VIP_MANAGEMENT=true + ENABLE_BGP_TOR=true (DevPreviewNoUpgrade, v4, 2 workers), followed by a verification step asserting the feature's acceptance criteria instead of the conformance suite: vipManagement=BGP on the Infrastructure CR, frr-k8s static pods (and no keepalived) on the control plane, the API VIP advertised to the ToR from every master and the ingress VIP from the workers, and the console answering over the BGP-routed path. Wired as an optional, on-demand presubmit on openshift/installer. The job is expected to fail until the feature PRs merge (installer#10718, MCO#6326, CNO#3047) and the dev-scripts knob lands (openshift-metal3/dev-scripts#1939); on installer#10718 itself the payload carries the PR's installer, so /test e2e-metal-ipi-bgp-vip exercises the flow end to end. Assisted-By: Claude Fable 5 Signed-off-by: Mat Kowalski <mko@redhat.com>
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot Bot
pushed a commit
to openshift/release
that referenced
this pull request
Jul 31, 2026
#82698) New baremetalds-e2e-bgp-vip workflow: dev-scripts baremetal IPI install with BGP_VIP_MANAGEMENT=true + ENABLE_BGP_TOR=true (DevPreviewNoUpgrade, v4, 2 workers), followed by a verification step asserting the feature's acceptance criteria instead of the conformance suite: vipManagement=BGP on the Infrastructure CR, frr-k8s static pods (and no keepalived) on the control plane, the API VIP advertised to the ToR from every master and the ingress VIP from the workers, and the console answering over the BGP-routed path. Wired as an optional, on-demand presubmit on openshift/installer. The job is expected to fail until the feature PRs merge (installer#10718, MCO#6326, CNO#3047) and the dev-scripts knob lands (openshift-metal3/dev-scripts#1939); on installer#10718 itself the payload carries the PR's installer, so /test e2e-metal-ipi-bgp-vip exercises the flow end to end. Assisted-By: Claude Fable 5 Signed-off-by: Mat Kowalski <mko@redhat.com>
openshift-merge-bot
Bot
merged commit Jul 31, 2026
cfcf4a7
into
openshift-metal3:master
16 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1929 (
ENABLE_BGP_TOR): a single switch that rendersplatform.baremetal.bgpVIPConfiginto the generated install-config, so a BGP-VIP-managed cluster (enhancement 1982, DevPreview; installer support in openshift/installer#10718) deploys with plainmakeinstead of hand-patching the install-config.BGP_VIP_MANAGEMENT=trueemits the config block; ASNs and peer address default to the OPNET-787: Add optional top-of-rack BGP speaker for the baremetal network #1929 ToR conventions (BGP_CLUSTER_ASN/BGP_TOR_ASN, ToR address = first IP of the external subnet), withBGP_VIP_PEER_ADDRESSas overrideENABLE_BGP_TORor without aFEATURE_SETenablingBGPBasedVIPManagement(DevPreviewNoUpgrade/CustomNoUpgrade) aborts early with a clear messageValidated on a live dev-scripts hypervisor: rendered block is byte-identical to the configuration used across 20+ validated BGP-VIP installs; guardrail paths exercised. A CI lane consuming this knob (openshift/release,
e2e-metal-ipi-bgp-vip) follows.This PR was prepared with AI assistance. Please verify before acting on it.