Update module k8s.io/klog/v2 to v2.140.0 - #1167
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 similar comments
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis change updates the indirect dependency ChangesDependency Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
509ae62 to
0da05f8
Compare
|
New changes are detected. LGTM label has been removed. |
0da05f8 to
9217b64
Compare
9217b64 to
1f3a490
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
go.mod (1)
153-153: 🔒 Security & Privacy | 🔵 TrivialAdd provenance attestation and signing for this dependency bump. SBOM generation is already in place, but Sigstore/cosign signing is not wired up here.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` at line 153, Add provenance attestation and Sigstore/cosign signing to the dependency-update workflow associated with the k8s.io/klog/v2 bump, reusing the existing SBOM generation flow. Ensure the resulting artifacts are signed and provenance attestations are emitted; do not modify the dependency version itself.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@go.mod`:
- Line 153: Add provenance attestation and Sigstore/cosign signing to the
dependency-update workflow associated with the k8s.io/klog/v2 bump, reusing the
existing SBOM generation flow. Ensure the resulting artifacts are signed and
provenance attestations are emitted; do not modify the dependency version
itself.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift-online/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 11a4d2d2-05cb-46d6-936b-b73d3d12c0e2
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
1f3a490 to
15c4ac4
Compare
This PR contains the following updates:
v2.130.1→v2.140.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
kubernetes/klog (k8s.io/klog/v2)
v2.140.0: Prepare klog release for Kubernetes v1.36Compare Source
What's Changed
New Contributors
Full Changelog: kubernetes/klog@v2.130.1...v2.140.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.