Build(deps): Bump k8s.io/apimachinery from 0.34.3 to 0.36.3 - #1218
Build(deps): Bump k8s.io/apimachinery from 0.34.3 to 0.36.3#1218dependabot[bot] wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 similar comments
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdates the Go toolchain directive and Kubernetes-related module dependencies in ChangesModule updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 3: Update the Go version configuration in the check-pull-request and
publish-release workflow definitions to use Go 1.26.0, matching the version
declared by go.mod. Replace the existing 1.25 and 1.23 pins while leaving the
surrounding CI and release steps unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift-online/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a112d737-6847-45af-a637-3add40c73f05
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.25.9 | ||
| go 1.26.0 |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
fd -HI -t f . | xargs -r rg -n \
'go-version|golang:[0-9]|^go 1\.|GO_VERSION|GOTOOLCHAIN'Repository: openshift-online/ocm-cli
Length of output: 801
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '--- go.mod ---\n'
cat -n go.mod | sed -n '1,40p'
printf '\n--- .github/workflows/check-pull-request.yaml ---\n'
cat -n .github/workflows/check-pull-request.yaml | sed -n '1,140p'
printf '\n--- .github/workflows/publish-release.yaml ---\n'
cat -n .github/workflows/publish-release.yaml | sed -n '1,120p'Repository: openshift-online/ocm-cli
Length of output: 253
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '--- go.mod ---'
sed -n '1,40p' go.mod | cat -n
echo
echo '--- .github/workflows/check-pull-request.yaml ---'
sed -n '1,140p' .github/workflows/check-pull-request.yaml | cat -n
echo
echo '--- .github/workflows/publish-release.yaml ---'
sed -n '1,120p' .github/workflows/publish-release.yaml | cat -n
echo
echo '--- other go-version/go pins ---'
rg -n --hidden --glob '!go.sum' --glob '!vendor/**' \
'go-version:|golang:[0-9]|^go 1\.|GO_VERSION|GOTOOLCHAIN' .Repository: openshift-online/ocm-cli
Length of output: 9765
Bump the Go version pins in CI and release workflows. go.mod now requires Go 1.26.0, but .github/workflows/check-pull-request.yaml still uses 1.25 and .github/workflows/publish-release.yaml still uses 1.23, so those jobs will fail until they’re updated too.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 3, Update the Go version configuration in the
check-pull-request and publish-release workflow definitions to use Go 1.26.0,
matching the version declared by go.mod. Replace the existing 1.25 and 1.23 pins
while leaving the surrounding CI and release steps unchanged.
Source: MCP tools
|
@dependabot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
981b198 to
d022708
Compare
|
New changes are detected. LGTM label has been removed. |
d022708 to
fe2fcde
Compare
|
rebase DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fe2fcde to
7cf1d39
Compare
|
rebase DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.34.3 to 0.36.3. - [Commits](kubernetes/apimachinery@v0.34.3...v0.36.3) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-version: 0.36.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
7cf1d39 to
092d8e3
Compare
Bumps k8s.io/apimachinery from 0.34.3 to 0.36.3.
Commits
40bf4b2Update dependencies to v0.36.3 tag34d46beMerge pull request #140296 from jpbetz/cherry-pick-smd-306-revert66a3724Bump sigs.k8s.io/structured-merge-diff/v6 to v6.3.32ec982dMerge pull request #139508lalitc375/automated-cherry-pick-of-#1394806a88102Fix wrong marking of errorsefb7f26Merge remote-tracking branch 'origin/master' into release-1.36d966e56Update github.com/moby/spdystream from v0.5.0 to v0.5.179b3632Merge pull request #137864 from yongruilin/dv-dra-mismatcha8822f7Add slice and map union member support with tests7dba2d0Use IsZero instead of IsNil for union ratcheting checkSummary by CodeRabbit