AGENT-1493: Promote NoRegistryClusterInstall Feature to Default

[sadasu]

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

[openshift-ci-robot]

@sadasu: This pull request references AGENT-1394 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target only the "5.0.0" version, but multiple target versions were set.

Details

In response to this:

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

This PR enables NoRegistryClusterInstall for Default and OKD profiles, updates its documentation and FeatureGate manifests, adds MachineConfigNode CRDs for SelfManagedHA Default and OKD, removes selected CRD annotations, and extends the feature-gate test analyzer with install-specific Sippy queries, thresholds, reporting, validation, and tests.

Possibly related PRs

• openshift/api#2943: Updates the same feature-gate analyzer and install-specific validation logic.

Suggested reviewers: joelspeed, everettraven

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 warning, 2 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Stable And Deterministic Test Names	❓ Inconclusive	placeholder	Need file evidence before final verdict.
Ipv6 And Disconnected Network Test Compatibility	❓ Inconclusive	pending investigation	Need to verify whether any newly added Ginkgo e2e tests exist in the changed files.

✅ Passed checks (12 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: promoting NoRegistryClusterInstall to the default feature set.
Description check	✅ Passed	The description is directly related and matches the change to enable NoRegistryClusterInstall by default for Agent installs.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Test Structure And Quality	✅ Passed	PR only adds standard Go unit tests, not Ginkgo specs; no cluster waits, cleanup, or timeout patterns apply.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added in the changed files; the PR only modifies codegen logic, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests were added; the PR only changes codegen logic, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only edits feature-gate metadata, CRDs, and codegen; no Deployment/Pod specs, affinity, nodeSelector, replicas, or PDBs were added.
Ote Binary Stdout Contract	✅ Passed	No OTE process-level entrypoints or suite setup were changed; the only stdout writes are helper diagnostics in the codegen tool, not main/init/TestMain/BeforeSuite code.
No-Weak-Crypto	✅ Passed	Patch only adds self-managed metal variants and formatting in the analyzer; no weak crypto, custom crypto, or secret/token comparisons were introduced.
Container-Privileges	✅ Passed	Touched files are CRDs, feature gates, docs, and Go code; no privileged/securityContext fields were present in the YAMLs.
No-Sensitive-Data-In-Logs	✅ Passed	Touched logging only prints feature-gate names, job variants, and generic Sippy status; no passwords, tokens, PII, or customer data appear.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @sadasu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@sadasu: This pull request references AGENT-1493 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sadasu]

/jira refresh

[openshift-ci-robot]

@sadasu: This pull request references AGENT-1493 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[yuqi-zhang]

Looks like the IRI object itself is still v1alpha1 only: https://github.com/openshift/api/blob/master/machineconfiguration/v1alpha1/types_internalreleaseimage.go ?

We don't allow GA'ing with a alpha API. We would need to graduate the API to v1 first, before we graduate the dependent feature.

[andfasano]

Do we require a separate PR for that?

[sadasu]

@andfasano Yes, lets create a separate PR for that.

[andfasano]

Requires #2863

[pawanpinjarkar]

@sadasu the dependent PR #2880 is merged. Please rebase and fix the the conflicts.

[JoelSpeed]

Do we have any specific periodic tests that demonstrate this feature behaving as described?

[andfasano]

Do we have any specific periodic tests that demonstrate this feature behaving as described?

Yes, we added four different TP periodic jobs to cover all the supported platform type/network/topology combinations, here: https://sippy.dptools.openshift.org/sippy-ng/jobs/5.0?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522variants%2522%252C%2522operatorValue%2522%253A%2522has%2520entry%2522%252C%2522value%2522%253A%2522never-stable%2522%252C%2522not%2522%253Atrue%257D%252C%257B%2522id%2522%253A99%252C%2522columnField%2522%253A%2522name%2522%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522iso-no-registry%2522%257D%255D%257D&sort=asc&sortField=net_improvement.

Please note that the latest PR for bumping the IRI api to v1 successfully landed on Friday, but we didn't yet get a freshly updated green 5.0 nightly payload, thus the current stripe of failures.
Given that the daily presubmits jobs are fine, I'd expect to have again green periodics as soon as a new green nightly will be available (rebuilt with the latest available images)

[JoelSpeed]

Could we please add a mapping that maps the iso-no-registry style jobs to the NoRegistryClusterInstall featuregate please?

[andfasano]

Could we please add a mapping that maps the iso-no-registry style jobs to the NoRegistryClusterInstall featuregate please?

Recently we did some work with TRT to add the mapping in Sippy CR openshift-eng/ci-test-mapping#767. We've been able also to start gathering some data from the aforementioned jobs, this view seems to work right now

[yuqi-zhang]

Functionally speaking the code is fine. I think this is ready for merge once feature-promotion is green

[sadasu]

/test verify-feature-promotion

verify-feature-promotion test is not able to find the NoRegistryClusterInstall jobs.
Will retest after openshift/sippy#3772.

[JoelSpeed]

/test verify-feature-promotion

[andfasano]

It looks like at least now the tests are fetched

[andfasano]

The fix for the single failing test openshift/origin#31394 landed and it was included in https://amd64.ocp.releases.ci.openshift.org/releasestream/5.0.0-0.nightly/release/5.0.0-0.nightly-2026-07-17-034502, so the trend should improve from the next green nightly (they are still red). The latest two runs per job installed and verified the cluster correctly, they just failed as per #31394

[andfasano]

/test verify-feature-promotion

[qodo-for-rh-openshift]

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

[andfasano]

/test verify-feature-promotion

[qodo-for-rh-openshift]

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

[andfasano]

/test verify-feature-promotion

[qodo-for-rh-openshift]

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

[andfasano]

/test verify-feature-promotion

[qodo-for-rh-openshift]

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

[andfasano]

@JoelSpeed @everettraven do you think we could be ready for approving the feature? After the nightlies have been stabilized we collected a solid stripe of green runs across all the OVE jobs in Sippy - and even before most of the failure were mostly technical and not strictly related to the feature. Thanks

[sadasu]

@andfasano I am working on the rebase and removing the changes to feature promotion code.

[sadasu]

/verified by CI

iso-no-registry Sippy jobs

[openshift-ci-robot]

@sadasu: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

iso-no-registry Sippy jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

Further analysis of the job results combined with improvements in #2944 shows strong signal that this feature is stable and ready to be promoted. Hypershift failure is a known rebase issue.

/lgtm
/approve

/override ci/prow/verify-feature-promotion
/override ci/prow/verify-hypershift-integration

[openshift-ci]

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-feature-promotion, ci/prow/verify-hypershift-integration

Details

In response to this:

Further analysis of the job results combined with improvements in #2944 shows strong signal that this feature is stable and ready to be promoted. Hypershift failure is a known rebase issue.

/lgtm
/approve

/override ci/prow/verify-feature-promotion
/override ci/prow/verify-hypershift-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 72624b9 and 2 for PR HEAD 1cabfcf in total

[bfournie]

/retest-required

[bfournie]

/retest-required

[openshift-ci]

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial-1of2	1cabfcf	link	true	/test e2e-aws-serial-1of2
ci/prow/e2e-azure	1cabfcf	link	true	/test e2e-azure
ci/prow/e2e-aws-serial-2of2	1cabfcf	link	true	/test e2e-aws-serial-2of2
ci/prow/e2e-upgrade-out-of-change	1cabfcf	link	true	/test e2e-upgrade-out-of-change
ci/prow/e2e-aws-ovn	1cabfcf	link	true	/test e2e-aws-ovn
ci/prow/e2e-gcp	1cabfcf	link	true	/test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sadasu]

/retest-required