Skip to content

[release-4.22] Add servicing annotation 4.22 - #517

Open
jacob-anders wants to merge 4 commits into
openshift:release-4.22from
jacob-anders:add-servicing-annotation-4.22
Open

[release-4.22] Add servicing annotation 4.22#517
jacob-anders wants to merge 4 commits into
openshift:release-4.22from
jacob-anders:add-servicing-annotation-4.22

Conversation

@jacob-anders

Copy link
Copy Markdown

No description provided.

jacob-anders and others added 2 commits July 31, 2026 19:19
…thout reboot

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c24b1da5-7a30-4786-b587-9a7824fd2c66

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from elfosardo and hroyrh July 31, 2026 09:36
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jacob-anders
Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jacob-anders and others added 2 commits July 31, 2026 19:57
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When an older Ironic that does not support the allow_grouping_reboots
step argument is used with batched firmware updates, the servicing
request fails asynchronously with "unexpected arguments:
allow_grouping_reboots". Detect this specific error and replace it
with a clear Metal3 error message advising the user to upgrade Ironic
or update components individually. Do not retry, since the same
request will fail the same way.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jacob-anders
jacob-anders force-pushed the add-servicing-annotation-4.22 branch from 01f01ee to df72674 Compare July 31, 2026 10:13
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

@jacob-anders: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant