CM-1297: Approver Policy: Add Helm manifest generation script and static manifests #482
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| kind: ClusterRole | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| labels: | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator | ||
| name: cert-manager-approver-policy | ||
| rules: | ||
| - apiGroups: ["policy.cert-manager.io"] | ||
| resources: ["certificaterequestpolicies"] | ||
| verbs: ["list", "watch"] | ||
| - apiGroups: ["policy.cert-manager.io"] | ||
| resources: ["certificaterequestpolicies/status"] | ||
| verbs: ["patch"] | ||
| - apiGroups: ["cert-manager.io"] | ||
| resources: ["certificaterequests"] | ||
| verbs: ["list", "watch"] | ||
| - apiGroups: ["cert-manager.io"] | ||
| resources: ["certificaterequests/status"] | ||
| verbs: ["patch"] | ||
| - apiGroups: ["cert-manager.io"] | ||
| resources: ["signers"] | ||
| verbs: ["approve"] | ||
| - apiGroups: ["rbac.authorization.k8s.io"] | ||
| resources: ["roles", "clusterroles", "rolebindings", "clusterrolebindings"] | ||
| verbs: ["list", "watch"] | ||
| - apiGroups: ["", "events.k8s.io"] | ||
| resources: ["events"] | ||
| verbs: ["create", "patch"] | ||
| - apiGroups: ["authorization.k8s.io"] | ||
| resources: ["subjectaccessreviews"] | ||
| verbs: ["create"] | ||
| - apiGroups: [""] | ||
| resources: ["namespaces"] | ||
| verbs: ["list", "watch"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| kind: ClusterRoleBinding | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| labels: | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator | ||
| name: cert-manager-approver-policy | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: cert-manager-approver-policy | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: cert-manager-approver-policy | ||
| namespace: cert-manager |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| --- | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: cert-manager-approver-policy | ||
| namespace: "cert-manager" | ||
| labels: | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator | ||
| spec: | ||
| replicas: 1 | ||
| selector: | ||
| matchLabels: | ||
| app: cert-manager-approver-policy | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app: cert-manager-approver-policy | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator | ||
| spec: | ||
| securityContext: | ||
| runAsNonRoot: true | ||
| seccompProfile: | ||
| type: RuntimeDefault | ||
| serviceAccountName: cert-manager-approver-policy | ||
| containers: | ||
| - name: cert-manager-approver-policy | ||
| image: "quay.io/jetstack/cert-manager-approver-policy:v0.27.0" | ||
| imagePullPolicy: IfNotPresent | ||
| ports: | ||
| - name: webhook | ||
| containerPort: 10250 | ||
| - name: metrics | ||
| containerPort: 9402 | ||
| - name: healthcheck | ||
| containerPort: 6060 | ||
| readinessProbe: | ||
| httpGet: | ||
| port: 6060 | ||
| path: "/readyz" | ||
| initialDelaySeconds: 3 | ||
| periodSeconds: 7 | ||
| args: | ||
| - --log-format=text | ||
| - --log-level=1 | ||
| - --metrics-bind-address=:9402 | ||
| - --readiness-probe-bind-address=:6060 | ||
| - --webhook-host=0.0.0.0 | ||
| - --webhook-port=10250 | ||
| - --webhook-service-name=cert-manager-approver-policy | ||
| - --webhook-ca-secret-namespace=cert-manager | ||
| - --webhook-ca-secret-name=cert-manager-approver-policy-tls | ||
| resources: {} | ||
|
There was a problem hiding this comment. 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win Set CPU and memory limits. Line 60 supplies no resource limits. This container can consume unbounded node CPU or memory. Define CPU and memory limits for the container. As per path instructions, “Resource limits (cpu, memory) on every container.” 🤖 Prompt for AI AgentsSource: Path instructions |
||
| securityContext: | ||
| allowPrivilegeEscalation: false | ||
| capabilities: | ||
| drop: | ||
| - ALL | ||
| readOnlyRootFilesystem: true | ||
| hostNetwork: false | ||
| dnsPolicy: ClusterFirst | ||
| nodeSelector: | ||
| kubernetes.io/os: linux | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| kind: Role | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| name: cert-manager-approver-policy | ||
| namespace: "cert-manager" | ||
| labels: | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator | ||
| rules: | ||
| - apiGroups: ["coordination.k8s.io"] | ||
| resources: ["leases"] | ||
| verbs: ["create"] | ||
| - apiGroups: ["coordination.k8s.io"] | ||
| resources: ["leases"] | ||
| verbs: ["get", "update"] | ||
| resourceNames: ["policy.cert-manager.io"] | ||
| - apiGroups: [""] | ||
| resources: ["secrets"] | ||
| verbs: ["get", "list", "watch", "create", "update"] | ||
| resourceNames: ['cert-manager-approver-policy-tls'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| kind: RoleBinding | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| name: cert-manager-approver-policy | ||
| namespace: "cert-manager" | ||
| labels: | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: Role | ||
| name: cert-manager-approver-policy | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: cert-manager-approver-policy | ||
| namespace: cert-manager |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: cert-manager-approver-policy-tls | ||
| namespace: "cert-manager" | ||
| annotations: | ||
| cert-manager.io/allow-direct-injection: "true" | ||
| labels: | ||
| app: cert-manager-approver-policy | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: cert-manager-approver-policy-metrics | ||
| namespace: "cert-manager" | ||
| labels: | ||
| app: cert-manager-approver-policy | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator | ||
| spec: | ||
| type: ClusterIP | ||
| ports: | ||
| - port: 9402 | ||
| targetPort: 9402 | ||
| protocol: TCP | ||
| name: metrics | ||
| selector: | ||
| app: cert-manager-approver-policy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: cert-manager-approver-policy | ||
| namespace: "cert-manager" | ||
| labels: | ||
| app: cert-manager-approver-policy | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator | ||
| spec: | ||
| type: ClusterIP | ||
| ports: | ||
| - port: 443 | ||
| targetPort: 10250 | ||
| protocol: TCP | ||
| name: webhook | ||
| selector: | ||
| app: cert-manager-approver-policy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: cert-manager-approver-policy | ||
| namespace: "cert-manager" | ||
| labels: | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| --- | ||
| apiVersion: monitoring.coreos.com/v1 | ||
| kind: ServiceMonitor | ||
| metadata: | ||
| name: cert-manager-approver-policy | ||
| namespace: "cert-manager" | ||
| labels: | ||
| app: cert-manager-approver-policy | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| prometheus: default | ||
| app.kubernetes.io/part-of: cert-manager-operator | ||
| spec: | ||
| jobLabel: cert-manager-approver-policy | ||
| selector: | ||
| matchLabels: | ||
| app: cert-manager-approver-policy | ||
| namespaceSelector: | ||
| matchNames: | ||
| - cert-manager | ||
| endpoints: | ||
| - port: metrics | ||
| path: "/metrics" | ||
| interval: 10s | ||
| scrapeTimeout: 5s | ||
|
Comment on lines
+15
to
+27
There was a problem hiding this comment. 🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win Add NetworkPolicy manifests for the approver-policy operand. This ServiceMonitor adds a scrape path to port 9402 and the Deployment adds a webhook listener on port 10250. The repository already ships per-operand NetworkPolicies for cert-manager and istio-csr under The existing policies select Add deny-all, metrics-ingress, webhook-ingress, and API-server-egress policies for this operand, to match the existing pattern. As per path instructions for 🤖 Prompt for AI AgentsSource: Path instructions |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| --- | ||
| apiVersion: admissionregistration.k8s.io/v1 | ||
| kind: ValidatingWebhookConfiguration | ||
| metadata: | ||
| name: cert-manager-approver-policy | ||
| labels: | ||
| app: cert-manager-approver-policy | ||
| app.kubernetes.io/name: cert-manager-approver-policy | ||
| app.kubernetes.io/instance: cert-manager-approver-policy | ||
| app.kubernetes.io/version: "v0.27.0" | ||
| app.kubernetes.io/managed-by: cert-manager-operator | ||
| app.kubernetes.io/part-of: cert-manager-operator | ||
| annotations: | ||
| cert-manager.io/inject-ca-from-secret: "cert-manager/cert-manager-approver-policy-tls" | ||
| webhooks: | ||
| - name: policy.cert-manager.io | ||
| rules: | ||
| - apiGroups: | ||
| - "policy.cert-manager.io" | ||
| apiVersions: | ||
| - "*" | ||
| operations: | ||
| - CREATE | ||
| - UPDATE | ||
| resources: | ||
| - certificaterequestpolicies | ||
| admissionReviewVersions: ["v1", "v1beta1"] | ||
| timeoutSeconds: 5 | ||
| failurePolicy: Fail | ||
| sideEffects: None | ||
| clientConfig: | ||
| service: | ||
| name: cert-manager-approver-policy | ||
| namespace: "cert-manager" | ||
| path: /validate-policy-cert-manager-io-v1alpha1-certificaterequestpolicy |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Add a liveness probe.
Line 44 defines only
readinessProbe. Kubernetes cannot restart a running container that stops serving its controller duties. Add a liveness probe that uses a health endpoint supported by the image.As per path instructions, “Liveness + readiness probes defined.”
🤖 Prompt for AI Agents
Source: Path instructions