Skip to content

[master] feat(functional): add util container to support vector move to ubi-micro - #3444

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
openshift-cherrypick-robot:cherry-pick-3438-to-master
Aug 31, 2026
Merged

[master] feat(functional): add util container to support vector move to ubi-micro#3444
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
openshift-cherrypick-robot:cherry-pick-3438-to-master

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 31, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #3438

/assign jcantrill

Summary by CodeRabbit

  • Tests
    • Improved functional test reliability by introducing a dedicated utility container for HTTP requests and metrics queries.
    • Updated metrics, API, output, and discarded-metrics tests to run diagnostic commands through the utility container.
    • Added a long-running utility environment based on a stable UBI image for functional test execution.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c0a58217-bb48-493c-ad89-2a5c70719f57

📥 Commits

Reviewing files that changed from the base of the PR and between edd266b and 7721464.

📒 Files selected for processing (7)
  • test/framework/functional/framework.go
  • test/framework/functional/metrics.go
  • test/framework/functional/write.go
  • test/functional/metrics/discarded_metrics_test.go
  • test/functional/metrics/metrics_test.go
  • test/functional/misc/vector_api_cli_test.go
  • test/functional/outputs/splunk/403_forbidden_test.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The functional test framework adds a long-running UBI utility container. Metric collection, HTTP input writes, health checks, and related functional tests now execute curl commands in this container.

Changes

Functional test utility container

Layer / File(s) Summary
Utility container setup
test/framework/functional/framework.go
Defines utility container constants and adds a long-running UBI utility container with IfNotPresent image pulling.
Command routing through the utility container
test/framework/functional/metrics.go, test/framework/functional/write.go, test/functional/metrics/*, test/functional/misc/vector_api_cli_test.go, test/functional/outputs/splunk/403_forbidden_test.go
Routes metric, HTTP input, and health-check curl commands through functional.UtilContainerName instead of the collector container.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 77214

This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Suggested reviewers: jcantrill, vparfonov

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states that this is an automated cherry-pick and assigns an approver, but it does not provide the mandatory change summary, reviewer assignment, or required links section. Add a concise description of the intent, context, rationale, and implementation. Add at least one /cc reviewer from the top-level OWNERS file. Include the Links section with applicable dependent PR, GitHub issue, JIRA, or enhancement propos…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding a functional-test utility container to support moving Vector to UBI Micro.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 7…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Resolution

Add a concise description of the intent, context, rationale, and implementation. Add at least one /cc reviewer from the top-level OWNERS file. Include the Links section with applicable dependent PR, GitHub issue, JIRA, or enhancement proposal references.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 7 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jcantrill

Copy link
Copy Markdown
Contributor

/retest

@jcantrill

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2026
@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2026
@jcantrill

Copy link
Copy Markdown
Contributor

/retest

@jcantrill

Copy link
Copy Markdown
Contributor

/label verified

@openshift-ci openshift-ci Bot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 31, 2026
@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 77b048b into openshift:master Aug 31, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.7 verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants