Use equals form for dnf installroot flags in Dockerfile.art - #3453
Conversation
rpm-lockfile-prototype misparses spaced dnf option values (e.g. --installroot /mnt/rootfs, --releasever 9) as package names until argument parsing is fixed upstream. Use --installroot= and --releasever= so hermetic lockfile generation sees only real packages. rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe builder-stage DNF installation and cleanup commands now use equals-form ChangesDNF syntax update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The Docker build keeps the same DNF packages and cleanup behavior while using option syntax compatible with hermetic RPM lockfile generation. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the change, its rationale, and the test plan. It does not include the mandatory /cc reviewer assignment or /assign approver assignment, and it omits the required Links section. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbladilo, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@fbladilo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Use
--installroot=and--releasever=inDockerfile.artinstead of spaced forms (--installroot /mnt/rootfs,--releasever 9).rpm-lockfile-prototype currently treats spaced dnf option values as package names when scanning Containerfiles for hermetic RPM lockfile generation. That breaks Konflux hermetic builds until upstream argument parsing is fixed. The
=form is equivalent for dnf and avoids the parser bug.Test plan
rpms.lock.yamldnfflagsSummary by CodeRabbit