Skip to content

Use equals form for dnf installroot flags in Dockerfile.art - #3453

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
fbladilo:fix/dnf-flag-equals-form
Sep 3, 2026
Merged

Use equals form for dnf installroot flags in Dockerfile.art#3453
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
fbladilo:fix/dnf-flag-equals-form

Conversation

@fbladilo

@fbladilo fbladilo commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Use --installroot= and --releasever= in Dockerfile.art instead of spaced forms (--installroot /mnt/rootfs, --releasever 9).

rpm-lockfile-prototype currently treats spaced dnf option values as package names when scanning Containerfiles for hermetic RPM lockfile generation. That breaks Konflux hermetic builds until upstream argument parsing is fixed. The = form is equivalent for dnf and avoids the parser bug.

Test plan

  • Konflux/hermetic build for cluster-logging-operator resolves the correct installroot packages into rpms.lock.yaml
  • Image build still succeeds with the updated dnf flags

Summary by CodeRabbit

  • Chores
    • Updated the container build configuration to use explicit installation-root and release-version settings.
    • Package installation, cleanup, and staging behavior remain unchanged.

rpm-lockfile-prototype misparses spaced dnf option values (e.g.
--installroot /mnt/rootfs, --releasever 9) as package names until
argument parsing is fixed upstream. Use --installroot= and
--releasever= so hermetic lockfile generation sees only real packages.

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: c3fc64b5-dfb2-44ec-8490-1eddbadbab4d

📥 Commits

Reviewing files that changed from the base of the PR and between 47e05e3 and 2065d31.

📒 Files selected for processing (1)
  • Dockerfile.art

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The builder-stage DNF installation and cleanup commands now use equals-form --installroot and --releasever options. Package selection, cleanup, and staging remain unchanged.

Changes

DNF syntax update

Layer / File(s) Summary
Update builder-stage DNF commands
Dockerfile.art
Builder-stage DNF commands use explicit --installroot=/mnt/rootfs and --releasever=9 syntax. Package selection and staging remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 2065d

The Docker build keeps the same DNF packages and cleanup behavior while using option syntax compatible with hermetic RPM lockfile generation. No current merge-blocking risk is identified.

Suggested reviewers: jcantrill, vparfonov, xperimental

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change, its rationale, and the test plan. It does not include the mandatory /cc reviewer assignment or /assign approver assignment, and it omits the required Links section… Add at least one reviewer with /cc and at least one approver with /assign, using entries from the top-level OWNERS file. Add the required Links section and complete each applicable link field, or mark fields as not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: replacing spaced DNF option values with equals-form flags in Dockerfile.art.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change, its rationale, and the test plan. It does not include the mandatory /cc reviewer assignment or /assign approver assignment, and it omits the required Links section.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jcantrill

Copy link
Copy Markdown
Contributor

/approve
/lgtm
/label verified

@openshift-ci openshift-ci Bot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 3, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2026
@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbladilo, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2026
@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@fbladilo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 316206e into openshift:master Sep 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.7 verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants