OCPBUGS-88301: Remove redundant delete role verb

[rhrmo]

No description provided.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@rhrmo: This pull request references Jira Issue OCPBUGS-88301, which is invalid:

• expected the bug to target either version "5.1.0." or "openshift-5.1.0.", but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: cdd51f7d-76c2-40b1-8ea1-7401a8f31c5e

📥 Commits

Reviewing files that changed from the base of the PR and between f7573c1 and 60be560.

⛔ Files ignored due to path filters (14)

• assets/overlays/aws-ebs/generated/hypershift/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/aws-ebs/generated/standalone/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/aws-efs/generated/standalone/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/azure-disk/generated/hypershift/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/azure-disk/generated/standalone/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/azure-file/generated/hypershift/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/azure-file/generated/standalone/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/gcp-pd/generated/hypershift/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/gcp-pd/generated/standalone/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/openstack-cinder/generated/hypershift/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/openstack-cinder/generated/standalone/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/openstack-manila/generated/hypershift/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/openstack-manila/generated/standalone/lease_leader_election_role.yaml is excluded by !**/generated/**
• assets/overlays/samba/generated/standalone/lease_leader_election_role.yaml is excluded by !**/generated/**

📒 Files selected for processing (1)

• assets/base/rbac/lease_leader_election_role.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The lease leader-election Role no longer grants the delete verb for leases. It retains get, watch, list, update, and create.

Merge Risk: ⚪ Minimal · up to 60be5

Lease leader-election access is narrowed by removing lease deletion permission without changing the remaining required access. The change is ready to merge.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided, so the change context is not documented in the description.	Add a brief description that explains the removal of the delete permission from the lease leader-election Role.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: removing the redundant delete verb from the lease leader-election role.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only RBAC YAML files. The exact diff removes the delete verb from the lease role and its generated overlays. It does not add or modify any test title, so it cannot int…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only RBAC YAML files. The diff removes the delete verb from the base role and generated overlays. It adds or modifies no Ginkgo tests, It blocks, setup or cleanup, w…
Microshift Test Compatibility	✅ Passed	The pull request changes only RBAC YAML manifests. The committed diff removes the delete verb from lease permissions and updates generated manifests. It adds no Ginkgo tests or other test code, so t…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request only removes the delete verb from lease-election RBAC YAML files. The target-to-HEAD diff changes 15 YAML files and adds no Ginkgo tests or other test declarations. Therefore,…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only RBAC Role manifests. It removes the delete verb from lease permissions in the base role and generated overlays. It does not modify deployment manifests, operator …
Ote Binary Stdout Contract	✅ Passed	PASS. The commit changes only 15 YAML RBAC manifests. It removes the delete verb from lease permissions and changes no Go process code, main, suite setup, logging, or stdout behavior. The OTE Bina…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request changes only RBAC YAML files. It removes the delete verb from the lease leader-election Role and generated overlays. No Ginkgo tests, IPv4 assumptions, or external connectivit…
No-Weak-Crypto	✅ Passed	PASS. The pull-request diff changes only Kubernetes RBAC YAML. It removes the delete verb from lease permissions in one base Role and its generated overlays. No MD5, SHA1, DES, 3DES, RC4, Blowfish, …
Container-Privileges	✅ Passed	PASS: The pull request changes only RBAC lease verb lists. It removes delete from assets/base/rbac/lease_leader_election_role.yaml and the generated lease-role manifests. The diff adds no `privile…
No-Sensitive-Data-In-Logs	✅ Passed	PASS. The pull request changes only RBAC YAML files. The source Role removes the delete verb from the leases rule, and generated Roles remove the same verb. No logging code or sensitive data was a…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[rhrmo]

/jira refresh

[openshift-ci-robot]

@rhrmo: This pull request references Jira Issue OCPBUGS-88301, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rhrmo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mpatlasov]

/retest

[mpatlasov]

/retest

[mpatlasov]

/pipeline required

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-azure-file-nfs-csi
/test e2e-azure-ovn-upgrade
/test e2e-gcp
/test e2e-gcp-csi
/test e2e-gcp-ovn-upgrade

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-csi-extended
/test e2e-azure-csi-extended
/test e2e-azure-csi-hypershift
/test e2e-azure-file-csi-extended
/test e2e-azure-file-csi-hypershift
/test e2e-azure-file-nfs-csi-hypershift
/test e2e-azurestack-csi
/test e2e-openstack
/test e2e-openstack-cinder-csi
/test e2e-openstack-manila-csi

[mpatlasov]

/test e2e-gcp

[mpatlasov]

/test e2e-openstack-cinder-csi

[mpatlasov]

/test e2e-gcp

[mpatlasov]

/test e2e-openstack-manila-csi

[mpatlasov]

/test hypershift-e2e-openstack-aws-csi-manila

[openshift-ci]

@rhrmo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/aws-efs-single-zone-operator-e2e-extended	60be560	link	false	/test aws-efs-single-zone-operator-e2e-extended
ci/prow/smb-win2019-operator-e2e	60be560	link	false	/test smb-win2019-operator-e2e
ci/prow/hypershift-e2e-openstack-aws-csi-cinder	60be560	link	true	/test hypershift-e2e-openstack-aws-csi-cinder
ci/prow/aws-efs-operator-e2e-extended	60be560	link	false	/test aws-efs-operator-e2e-extended
ci/prow/smb-win2022-operator-e2e	60be560	link	false	/test smb-win2022-operator-e2e
ci/prow/hypershift-aws-e2e-external	60be560	link	true	/test hypershift-aws-e2e-external
ci/prow/e2e-azure-file-nfs-csi-hypershift	60be560	link	false	/test e2e-azure-file-nfs-csi-hypershift
ci/prow/e2e-aws-csi-extended	60be560	link	false	/test e2e-aws-csi-extended
ci/prow/e2e-azure-csi-extended	60be560	link	false	/test e2e-azure-csi-extended
ci/prow/e2e-gcp-csi	60be560	link	true	/test e2e-gcp-csi
ci/prow/e2e-openstack	60be560	link	false	/test e2e-openstack
ci/prow/e2e-azure-csi-hypershift	60be560	link	false	/test e2e-azure-csi-hypershift
ci/prow/e2e-azure-file-csi-extended	60be560	link	false	/test e2e-azure-file-csi-extended
ci/prow/e2e-azure-file-csi-hypershift	60be560	link	false	/test e2e-azure-file-csi-hypershift
ci/prow/e2e-azurestack-csi	60be560	link	false	/test e2e-azurestack-csi
ci/prow/hypershift-e2e-openstack-aws-csi-manila	60be560	link	true	/test hypershift-e2e-openstack-aws-csi-manila
ci/prow/e2e-openstack-manila-csi	60be560	link	true	/test e2e-openstack-manila-csi
ci/prow/e2e-openstack-cinder-csi	60be560	link	true	/test e2e-openstack-cinder-csi
ci/prow/e2e-gcp	60be560	link	true	/test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.