Skip to content

Update to Perses 0.54.0 - #306

Open
andreasgerstmayr wants to merge 1 commit into
openshift:mainfrom
andreasgerstmayr:update-perses-0.54.0
Open

Update to Perses 0.54.0#306
andreasgerstmayr wants to merge 1 commit into
openshift:mainfrom
andreasgerstmayr:update-perses-0.54.0

Conversation

@andreasgerstmayr

@andreasgerstmayr andreasgerstmayr commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added support for the latest stable Perses integration.
    • Added trace table functionality for viewing trace results.
    • Updated trace detail and query browsing to use the current trace query format.
  • Improvements

    • Improved plugin loading and compatibility across trace visualizations.
    • Updated trace data handling to align with the latest Perses specifications.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreasgerstmayr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6621e0b3-5e0e-476d-9d02-b6c3b08d7708

📥 Commits

Reviewing files that changed from the base of the PR and between 601ecd8 and 4786c1b.

⛔ Files ignored due to path filters (1)
  • web/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (7)
  • pkg/api/tempo.go
  • web/package.json
  • web/src/components/PersesWrapper.tsx
  • web/src/pages/TraceDetailPage/TraceDetailPage.tsx
  • web/src/pages/TraceDetailPage/transformTrace.ts
  • web/src/pages/TracesPage/QueryBrowser.tsx
  • web/src/pages/TracesPage/TracesPage.tsx

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The web client updates Perses dependencies to stable releases, adopts the plugin registry and datasource definition APIs, updates trace query configuration, removes page memoization, and adds commented Tempo resource examples for local development.

Changes

Perses API migration

Layer / File(s) Summary
Stable Perses packages and types
web/package.json, web/src/components/PersesWrapper.tsx, web/src/pages/TraceDetailPage/transformTrace.ts
Perses dependencies and type imports move to stable packages.
Plugin registry loading
web/src/components/PersesWrapper.tsx
Dynamic plugin modules are converted into registry mappings keyed by compound plugin metadata.
Trace datasource integration
web/src/components/PersesWrapper.tsx, web/src/pages/TraceDetailPage/TraceDetailPage.tsx, web/src/pages/TracesPage/QueryBrowser.tsx, web/src/pages/TracesPage/TracesPage.tsx
Trace datasource configuration uses typed definitions arrays with nested Tempo query specifications. Trace pages export directly instead of through memo.

Tempo local development data

Layer / File(s) Summary
Commented Tempo examples
pkg/api/tempo.go
Commented example resources are added for two local-development TempoStack instances. Runtime Kubernetes listing remains unchanged.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 4786c

This upgrades Perses and migrates trace datasource configuration to the stable API without identified runtime or data-impacting issues. The change is ready to merge.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 6 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating the project to Perses 0.54.0. It is concise and specific.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request does not change test files or add Ginkgo title calls. The changed Go file only adds commented mock data with static example names, and the code is not a test title. No dynamic test ti…
Test Structure And Quality ✅ Passed PASS — The pull request does not add or modify Ginkgo tests. The scoped diff changes application Go code, web dependencies, and React/TypeScript code only. The added Tempo mock is fully commented out …
Microshift Test Compatibility ✅ Passed The authoritative pull-request diff changes only pkg/api/tempo.go, dependency files, and web TypeScript/TSX files. It adds no *_test.go files, no Ginkgo constructs (It, Describe, Context, or…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The authoritative pull-request diff changes eight existing files and adds no Ginkgo e2e tests. The added lines contain no It, Describe, Context, or When declarations. The Go change only …
Topology-Aware Scheduling Compatibility ✅ Passed PASS. The pull request changes frontend Perses integration, dependency lockfiles, and adds only commented mock data in pkg/api/tempo.go. The diff adds no deployment manifests, operator/controller sc…
Ote Binary Stdout Contract ✅ Passed PASS. The authoritative diff changes one Go file, pkg/api/tempo.go, by adding five comment-only lines. The mock return block is fully commented and cannot write to stdout. No changed Go code adds …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The check is not applicable. The reviewed range changes eight files, with no added Go test or e2e file. The patch adds no Ginkgo declarations such as It, Describe, Context, or When, and adds n…
No-Weak-Crypto ✅ Passed No prohibited cryptography was introduced. The review-scoped diff adds no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison logic. The lockfile changes add or update Perse…
Container-Privileges ✅ Passed PASS. The pull request changes Go application code, web dependencies, and TypeScript files only. It does not change Kubernetes, Helm, Docker, or container manifests. The patch introduces no `privilege…
No-Sensitive-Data-In-Logs ✅ Passed No new logging was introduced. The only added Go code is commented mock Tempo data, and the web changes update imports, plugin registration, and query definitions. Existing logrus calls in `pkg/api/…
Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 6 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant