Skip to content

HIVE-2382: Reproduce user-provisioned DNS with AWS PrivateLink - #2936

Draft
bandrade wants to merge 4 commits into
openshift:masterfrom
bandrade:HIVE-2382-privatelink-reproduction
Draft

HIVE-2382: Reproduce user-provisioned DNS with AWS PrivateLink#2936
bandrade wants to merge 4 commits into
openshift:masterfrom
bandrade:HIVE-2382-privatelink-reproduction

Conversation

@bandrade

Copy link
Copy Markdown

Experimental CI-only reproduction for the remaining OCP-83733 AWS PrivateLink scenario.

This is intentionally separate from #2933 so the reviewed public ClusterDeployment and ClusterPool coverage remains merge-ready.

The change:

  • enables the existing full AWS PrivateLink lifecycle scenario;
  • renders userProvisionedDNS: Enabled in its private install-config;
  • retains the existing endpoint VPC, Hive PrivateLink, installation, reachability, and teardown flow.

Validation:

  • go test -vet=off ./hive -run '^$'
  • make build
  • make -f bindata.mk verify-testdata
  • extension discovery lists the PrivateLink OCP-83733 scenario

Depends on #2933. Do not merge; this PR is for the targeted periodic reproduction and evidence collection.

bandrade added 3 commits July 29, 2026 12:38
Port the ClusterDeployment and ClusterPool scenarios from OCP-83733 into the Hive OTE suite. The tests publish and clean up their own API and ingress DNS records, verify Hive does not create a managed DNSZone, and prove the installed clusters are reachable.

Assisted-by: GPT-5
Wait for Route 53 changes to reach INSYNC before tests continue or cleanup completes.

Assisted-by: GPT-5
Enable the existing AWS PrivateLink lifecycle scenario with user-provisioned DNS so it can be exercised in the Hive periodic environment.

Assisted-by: GPT-5
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 30, 2026

Copy link
Copy Markdown

@bandrade: This pull request references HIVE-2382 which is a valid jira issue.

Details

In response to this:

Experimental CI-only reproduction for the remaining OCP-83733 AWS PrivateLink scenario.

This is intentionally separate from #2933 so the reviewed public ClusterDeployment and ClusterPool coverage remains merge-ready.

The change:

  • enables the existing full AWS PrivateLink lifecycle scenario;
  • renders userProvisionedDNS: Enabled in its private install-config;
  • retains the existing endpoint VPC, Hive PrivateLink, installation, reachability, and teardown flow.

Validation:

  • go test -vet=off ./hive -run '^$'
  • make build
  • make -f bindata.mk verify-testdata
  • extension discovery lists the PrivateLink OCP-83733 scenario

Depends on #2933. Do not merge; this PR is for the targeted periodic reproduction and evidence collection.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a205a16a-9fb4-45ed-a0ef-ebc693871477

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bandrade

Copy link
Copy Markdown
Author

/payload-job-with-prs periodic-ci-openshift-hive-master-periodic-e2e-ote-sd-rosa #2936

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@bandrade: the repo openshift/hive does not contribute to the OpenShift official images, or the base branch is not currently having images promoted

@bandrade

Copy link
Copy Markdown
Author

/testwith openshift/hive/master/periodic/e2e-ote-sd-rosa

@bandrade

Copy link
Copy Markdown
Author

/testwith openshift/hive/master/periodic/e2e-ote-sd-rosa #2936

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bandrade
Once this PR has been reviewed and has the lgtm label, please assign suhanime for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bandrade

Copy link
Copy Markdown
Author

/testwith openshift/hive/master/periodic/e2e-ote-sd-rosa #2936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants