fix: OCPBUGS-58422: Allow disabling Ingress without Console in HyperShift - #8933
fix: OCPBUGS-58422: Allow disabling Ingress without Console in HyperShift#8933stefanonardo wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@stefanonardo: This pull request references Jira Issue OCPBUGS-58422, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (yapei@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stefanonardo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (34)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis change removes the validation rule that required Changes
Related PRs: None identified. Suggested labels: api-review, ok-to-test Suggested reviewers: None identified. 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/hold depends on openshift/console-operator#1182 |
|
@stefanonardo: This pull request references Jira Issue OCPBUGS-58422, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (yapei@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
b8f45ab to
a6096ed
Compare
|
@stefanonardo: This pull request references Jira Issue OCPBUGS-58422, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (yapei@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8933 +/- ##
==========================================
- Coverage 43.36% 43.36% -0.01%
==========================================
Files 771 771
Lines 95567 95563 -4
==========================================
- Hits 41444 41440 -4
Misses 51240 51240
Partials 2883 2883
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Remove the validation that requires Console to be disabled when Ingress is disabled. The console-operator now handles ingress-disabled gracefully (openshift/console-operator#1182). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
a6096ed to
50191c7
Compare
|
@stefanonardo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I now have complete evidence for the root cause. Let me produce the final report. Test Failure Analysis CompleteJob Information
Test Failure AnalysisErrorSummaryThe Root CauseThe failure chain is:
This is a transient upstream issue with Microsoft's RPM package infrastructure. The PR #8933 does not modify Recommendations
Evidence
|
Summary
Remove the validation that requires Console capability to be disabled when Ingress capability is disabled. The console-operator now handles ingress-disabled gracefully (openshift/console-operator#1182), so this constraint is no longer needed.
Changes
Ingress disabled → Console disabledDepends on
Test plan
go test ./cmd/cluster/core/ -run TestValidatepasses — all ingress-related test cases pass--disable-cluster-capabilities Ingress(Console enabled) was created and the console-operator ran without errorsSummary by CodeRabbit