Skip to content

add optional dualstack-v6primary for k8s 4.20, 4.21 - #82242

Open
jluhrsen wants to merge 1 commit into
openshift:mainfrom
jluhrsen:OCPBUGS-99230
Open

add optional dualstack-v6primary for k8s 4.20, 4.21#82242
jluhrsen wants to merge 1 commit into
openshift:mainfrom
jluhrsen:OCPBUGS-99230

Conversation

@jluhrsen

@jluhrsen jluhrsen commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

always_run: false

Summary by CodeRabbit

Adds optional dualstack-v6primary OpenStack end-to-end coverage for Kubernetes 4.20 and 4.21. The test targets the openstack-hwoffload profile, uses the openshift-e2e-openstack-dualstack workflow, and is configured with always_run: false.

always_run: false

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b36469b0-f2a3-4e9a-be28-81d534e313c6

📥 Commits

Reviewing files that changed from the base of the PR and between a7c6ed7 and d2777e8.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/kubernetes/openshift-kubernetes-release-4.20-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/kubernetes/openshift-kubernetes-release-4.21-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.20.yaml
  • ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.21.yaml

Walkthrough

Added an optional e2e-openstack-dualstack-v6primary test to the OpenShift 4.20 and 4.21 release pipeline configurations, targeting the openstack-hwoffload profile with the dualstack-v6primary configuration.

Changes

OpenStack dual-stack test

Layer / File(s) Summary
Configure the v6primary OpenStack test
ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.20.yaml, ci-operator/config/openshift/kubernetes/openshift-kubernetes-release-4.21.yaml
Adds the optional e2e-openstack-dualstack-v6primary test with openstack-hwoffload, CONFIG_TYPE: dualstack-v6primary, and the openshift-e2e-openstack-dualstack workflow.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding optional dualstack-v6primary support for Kubernetes 4.20 and 4.21.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The only new test/job name is the static string e2e-openstack-dualstack-v6primary; no Ginkgo titles or dynamic identifiers were added.
Test Structure And Quality ✅ Passed PR only adds ci-operator config/job YAML for e2e-openstack-dualstack-v6primary; no Ginkgo test code or It blocks are present to evaluate.
Microshift Test Compatibility ✅ Passed Only CI job entries were added in YAML; no Ginkgo test definitions or bodies changed, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: This PR only adds CI config for an existing OpenStack dualstack workflow; no new Ginkgo test code or SNO-sensitive test changes were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator e2e job entries were added; no manifests, controllers, or topology-sensitive scheduling fields were introduced.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML was added; no OTE binary code or process-level stdout writes changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI config was added; it reuses the existing OpenStack dualstack workflow with v6primary support and no new IPv4-only or external-network assumptions.
No-Weak-Crypto ✅ Passed PR only adds CI job YAML; added lines contain no weak crypto, custom crypto, or secret/token comparisons.
Container-Privileges ✅ Passed The added e2e-openstack-dualstack-v6primary job has no privileged/root/securityContext fields; only cluster_profile, env, and workflow are set.
No-Sensitive-Data-In-Logs ✅ Passed PASS: The PR only adds CI job/config entries; no log statements or debug output were added, and no secrets/PII are exposed in the new YAML.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from bertinatto and jacobsee July 21, 2026 16:51
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jluhrsen: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kubernetes-release-4.20-e2e-openstack-dualstack-v6primary openshift/kubernetes presubmit Presubmit changed
pull-ci-openshift-kubernetes-release-4.21-e2e-openstack-dualstack-v6primary openshift/kubernetes presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/kubernetes/release-4.20/e2e-openstack-dualstack-v6primary d2777e8 link unknown /pj-rehearse pull-ci-openshift-kubernetes-release-4.20-e2e-openstack-dualstack-v6primary
ci/rehearse/openshift/kubernetes/release-4.21/e2e-openstack-dualstack-v6primary d2777e8 link unknown /pj-rehearse pull-ci-openshift-kubernetes-release-4.21-e2e-openstack-dualstack-v6primary

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jluhrsen

Copy link
Copy Markdown
Contributor Author

@bertinatto @neisw , could you PTAL at this. just adding always_run: false and optional: true jobs to k8s so I can run rehearsals on origin PRs backporting a v6 fix

@neisw

neisw commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2026
@jubittajohn

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jluhrsen, jubittajohn, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants