Give every contributor URN the same shape - #17
Merged
Conversation
Two shapes were in production and denoted the same people under different URNs, so
a credits list showed Efraim Feinstein twice. One shape, with the type segment that
text: and condition: already have:
urn:x-opensiddur:contributor:<namespace>/<identifier>
195 files, one line each. No other change.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two URN shapes were in production and denoted the same people under different URNs, so a
credits list showed Efraim Feinstein twice. This settles on one, with the type segment that
text:andcondition:already have:195 files, one line each, no other change:
Only two identifiers were affected —
opensiddur.org/efraim-feinsteinandopensiddur.org/eve-feinstein. Everything else in the corpus was already in the canonicalshape,
jps1917included.Goes with opensiddur/opensiddur-ai#104
That PR's
latex.pyis what reads this prefix, in_contributor_of. The two are safe tomerge in either order — a reference that is not a contributor URN is reported and listed
without a namespace rather than dropped — but the pair is what makes a credits list name
each person once.
Verification
grep -rc 'urn:x-opensiddur:opensiddur\.org/' project/finds nothing left.feat/birnbaum-he-importer, whereit was first found.
🤖 Generated with Claude Code