chore(ers): add array-valued claims BDD coverage - #3839
Conversation
Test that array claims (e.g., groups: ["engineering", "devops"]) survive the full multi-strategy ERS pipeline through to authorization decisions. Uses .groups[] wildcard selector for subject condition sets since the flattening library produces indexed/wildcard keys, not plain array keys. Three scenarios: matching element PERMIT, no match DENY, anyOf with multiple attribute values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ken Ho <kho@virtru.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds BDD coverage for array-valued ChangesArray-valued claims ERS coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
groups: ["engineering", "devops"]) survive the full pipeline: claims provider → output mapping → flattening → subject mapping evaluation → authorization decision.groups[]wildcard selector in subject condition sets — the flattening library produces indexed/wildcard keys, not a plain.groupskey for arraysScenarios
groups: ["engineering", "devops"]groups: ["marketing", "sales"]groups: ["security", "devops"]matchessecurityTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit