Skip to content

Add Switch Attribute Explainer - #1470

Merged
gregwhitworth merged 4 commits into
openui:mainfrom
andresrega-msft:switch-attribute
Jul 16, 2026
Merged

Add Switch Attribute Explainer#1470
gregwhitworth merged 4 commits into
openui:mainfrom
andresrega-msft:switch-attribute

Conversation

@andresrega-msft

Copy link
Copy Markdown
Contributor

Add Switch Attribute Explainer

@netlify

netlify Bot commented Jul 2, 2026

Copy link
Copy Markdown

👷 Deploy request for open-ui accepted.

Name Link
🔨 Latest commit 41be3b3
🔍 Latest deploy log https://app.netlify.com/projects/open-ui/deploys/6a466da287d2510008616d72

Comment thread site/src/pages/components/switch.attribute.explainer.mdx Outdated
@annevk

annevk commented Jul 2, 2026

Copy link
Copy Markdown

Also how does this relate to #1376?

@lukewarlow lukewarlow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Anne has pointed out there's an existing explainer. This should redirect from the old explainer and the old one should be moved, deleted or otherwise handled so we don't have two show up. Feel free to link back to the old one from the new one

Comment thread site/src/pages/components/switch.attribute.explainer.mdx Outdated
Comment thread site/src/pages/components/switch.attribute.explainer.mdx Outdated
@gregwhitworth

Copy link
Copy Markdown
Member

As Anne has pointed out there's an existing explainer. This should redirect from the old explainer and the old one should be moved, deleted or otherwise handled so we don't have two show up. Feel free to link back to the old one from the new one

Let's keep and link to it, don't delete it but keep the same URL so that anyone that linked to the prior one it still functions as expected. There's valid research in the prior one that we should retain

@andresrega-msft

andresrega-msft commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@annevk @gregwhitworth @lukewarlow The new explainer links to the old one in the "Alternative proposal" section and in "Alternatives Considered." Please let me know if this is insufficient in any way. Also, the old explainer will stay at its current URL, no changes to it in this PR. Thanks!

@andresrega-msft
andresrega-msft marked this pull request as ready for review July 8, 2026 18:03
Comment thread site/src/pages/components/switch.attribute.explainer.mdx
Comment thread site/src/pages/components/switch.attribute.explainer.mdx
Comment thread site/src/pages/components/switch.attribute.explainer.mdx Outdated
Comment thread site/src/pages/components/switch.attribute.explainer.mdx

@gregwhitworth gregwhitworth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but one nit, you have dual counting occurring. Thanks for the work on this

Image

@gregwhitworth
gregwhitworth requested a review from lukewarlow July 16, 2026 15:02
@gregwhitworth

Copy link
Copy Markdown
Member

@lukewarlow friendly ping on the review here

@lukewarlow

Copy link
Copy Markdown
Collaborator

LGTM happy to iterate on this.

@gregwhitworth
gregwhitworth merged commit 8d561be into openui:main Jul 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants