luci-app-irqbalance: show the interrupts as a table, not a textarea - #8980
Merged
Conversation
openwrt
Bot
added
the
not following guidelines
The page printed /proc/interrupts into a read-only ui.Textarea and the
service state into a bare <p>. Neither is something a theme can lay out:
the
snapshot is a monospace block that scrolls sideways on a phone, and the
status paragraph sits alone in a section with no label beside it.
Same data, stock widgets:
* status becomes form rows -- service state, CPU count, hardware IRQ
count, and the busiest interrupt -- so it folds like every other page;
* the snapshot becomes two LuCI tables, hardware IRQs and the software
and inter-processor counters, with one column per CPU, a total, and the
device the line belongs to. Every cell carries data-title, which is
what
a theme keys its narrow-screen layout off;
* interrupts that have never fired are collapsed behind a checkbox. On a
four-core router that is 6 rows instead of 18, and the count is stated
beside the toggle;
* the numbers refresh in place on the existing poll rather than being
rebuilt, so the page does not move under the reader;
* Exclude IRQs offers each IRQ with the device that owns it, instead of
listing valid values in the description for the reader to match by hand
against the snapshot.
The settings are unchanged: same options, same defaults, same validation.
No stylesheet is added and no colour is hardcoded -- the running/not
running
state uses the --success-color-high / --error-color-high variables themes
export, with a literal fallback for themes that define neither.
Measured on a live GL-MT6000 (OpenWrt 25.12.5): 6 of 18 hardware IRQs shown
collapsed, 18 expanded, counters advancing on each tick with the scroll
offset unmoved.
Signed-off-by: Ivan Kvashonkin <vizzlef@gmail.com>
VizzleTF
force-pushed
the
luci-app-irqbalance-page
branch
from
August 25, 2026 11:59
be9132a to
ca66057
Compare
openwrt
Bot
removed
the
not following guidelines
Contributor
Author
|
@hnyman here we go |
Contributor
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page printed
/proc/interruptsinto a read-onlyui.Textareaand the servicestate into a bare
<p>. This renders the same data with stock LuCI widgets, so atheme can lay it out and a phone can read it.
What changes:
busiest interrupt — instead of a paragraph alone in a section.
inter-processor counters. One column per CPU, a total, and the device the line
belongs to. Cells carry
data-title, which is what themes key theirnarrow-screen layout off.
on a four-core router, with the count stated beside the toggle.
so the page does not move under the reader.
valid values in the description to match by hand against the snapshot.
Settings are unchanged: same options, same defaults, same validation. No
stylesheet is added and no colour is hardcoded — running/not running uses the
--success-color-high/--error-color-highvariables themes export, with aliteral fallback.
Measured on a live GL-MT6000 (OpenWrt 25.12.5): 6 of 18 hardware IRQs collapsed,
18 expanded, counters advancing each tick with the scroll offset unmoved.
Context: the page came up in #8903, where the spacing under the textarea was
reported and before/after screenshots of this rewrite were posted.