[DRAFT, do not merge yet] udp-broadcast-relay-redux: Add package back (re-pointed at new fork location)

[accwebs]

📦 Package Details

Maintainer: @accwebs

Description:
This brings back the udp-broadcast-relay-redux package that was dropped in #29452. @accwebs has forked the now-archived upstream and is re-pointed at the new fork location in this PR.

Still a DRAFT PR: Want to ensure this package builds again on both bleeding edge and 25.12.x. And want to re-test the init scripts, etc. Please do not merge this yet.

---

🧪 Run Testing Details

• OpenWrt Version: 25.12.x (TBD)
• OpenWrt Target/Subtarget: TBD
• OpenWrt Device: GL-MT6000

---

✅ Formalities

• I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

[openwrt]

Formality Check: Failed

We completed the verification flow. Please review the formatting overview logs below.

🛑 CRITICAL ERRORS

Commit e174336 - udp-broadcast-relay-redux: revert "udp-broadcast-relay-redux: remove package":

• New OpenWrt package is missing the mandatory parameter: 'PKG_MAINTAINER'
• New OpenWrt package is missing the mandatory parameter: 'PKG_LICENSE_FILES'
• Makefile line 'This program listens for packets on a specified UDP broadcast port.' inside 'Package/udp-broadcast-relay-redux/description' must be indented with at least 2 spaces
• Makefile line 'When a packet is received, it sends that packet to all specified interfaces but' inside 'Package/udp-broadcast-relay-redux/description' must be indented with at least 2 spaces
• Makefile line 'the one it came from as though it originated from the original sender.' inside 'Package/udp-broadcast-relay-redux/description' must be indented with at least 2 spaces
• Makefile line 'The primary purpose of this is to allow games on machines on separated' inside 'Package/udp-broadcast-relay-redux/description' must be indented with at least 2 spaces
• Makefile line 'local networks (Ethernet, WLAN) that use udp broadcasts to find each other to do so.' inside 'Package/udp-broadcast-relay-redux/description' must be indented with at least 2 spaces
• Makefile line 'It also works on ppp links, so you can log in from windows boxes (e.g. using pptp)' inside 'Package/udp-broadcast-relay-redux/description' must be indented with at least 2 spaces
• Makefile line 'and play LAN-based games together. Currently, you have to care about upcoming or' inside 'Package/udp-broadcast-relay-redux/description' must be indented with at least 2 spaces
• Makefile line 'downgoing interfaces yourself.' inside 'Package/udp-broadcast-relay-redux/description' must be indented with at least 2 spaces

Tip

Do not close this pull request to make corrections. Instead, modify your existing commits (e.g. git commit --amend) and update the branch using git push --force-with-lease --force-if-includes. The checks will re-run automatically.

---

_{Something broken? Consider reporting an issue.
Running version d8f0c4e deployed on 2026-07-28 08:57:39 CEST}

[openwrt-ai]

Reviewed 4 new commits.

Verified out-of-band: the fork accwebs/udp-broadcast-relay-redux exists, aa9adef316824e88a28b0e19a4a7a29ababe92fc is the current master HEAD, LICENSE is present at that commit (GPLv2 text), and main.c is byte-identical to the previously packaged commit 6713729, so all of --id/--port/--dev/-s/-t/--multicast used by the init script still parse. The reverted SHA 90b98c1 in fde50d4 is correct and the revert is faithful.

Commit checks

• cbf1189 "udp-broadcast-relay-redux: switch package to new fork location" — missing blank line between subject and body, so the bullet list is folded into the subject. git log --oneline renders it as one 150-character subject: udp-broadcast-relay-redux: switch package to new fork location * Point at new location https://github.com/accwebs/udp-broadcast-relay-redux * Update to latest commit hash. Insert a blank line after the subject.
• afbadf9 "udp-broadcast-relay-redux: update package Makefile to modern conventions" — same problem; the three * Add ... bullets are part of the subject line rather than the body.

---

Generated by Claude Code

[openwrt-ai]

Reviewed 2 new commits (ef8a406, d2c6058) since my last review at afbadf9; the branch was force-pushed, so dcdb1a1/ef8a406 are the rewritten versions of cbf1189/afbadf9.

The commit-message folding I flagged last time is fixed — both rewritten commits now have a proper blank line between subject and body, and FormalityCheck / Git & Commits is green. Both new commit messages match their diffs, so no commit checks this round.

Verified out-of-band against accwebs/udp-broadcast-relay-redux@aa9adef3: LICENSE is present and is the GPLv2 text, and main.c's header reads "either version 2 of the License, or (at your option) any later version", so the PKG_LICENSE:=GPL-2.0-or-later change is correct. PKG_SOURCE_DATE:=2026-07-26 also matches that commit's date.

Inline: the build is red on all 10 targets for a fixable reason (stale PKG_MIRROR_HASH), the Makefile formality check is red for a series-hygiene reason, and the tab conversion in the init script flattened two levels of nesting.

---

Generated by Claude Code

[openwrt-ai]

Reviewed the force-pushed series (5 commits) since my last review at d2c6058. All three previously flagged items are fixed:

• PKG_MIRROR_HASH is now 5462b1d1…, and every target gets past download and compiles.
• The init script is consistently hard-tab indented; the two flattened blocks (|| { … } and the for net loop) now nest correctly, and the uci_validate_section continuation lines were indented as well.
• The new commit 0481de6 renames net/udp-broadcast-relay-redux-openwrt/ → net/udp-broadcast-relay-redux/, aligning the directory with PKG_NAME. Verified content-neutral (R100 on all three files), and there are no leftover references to the old path anywhere in the feed.

Verified locally against the base checkout:

• a8d4687 is a faithful revert — the restored tree is byte-identical to 90b98c14^:net/udp-broadcast-relay-redux-openwrt, and 90b98c14 is indeed the removal commit.
• PKG_VERSION is intentionally absent; include/download.mk derives it from PKG_SOURCE_DATE/PKG_SOURCE_VERSION, which matches the 2026.07.26~aa9adef3-r1 the CI installs. PKG_RELEASE reset to 1 in 7a358be is correct for a source bump.
• The init script is functionally sound: procd_open_instance with no name auto-numbers via _procd_open_instance, so the multi-section case doesn't collide, and cgroupsns is a valid procd_add_jail flag. conffiles is unindented with a correct absolute path.

All five commit messages match their diffs, so no commit checks this round.

One new inline finding: the five targets that run the runtime suite now fail on the generic version check rather than on the build. That is the documented test-version.sh case, not a defect in the code.

FormalityCheck / OpenWrt Makefiles is still red on a8d4687 for the introduce-then-fix reason I raised on the two previous rounds — not repeating it inline since the existing thread still anchors to the current Makefile. Worth folding before undrafting if you want the not following guidelines label to clear, but it is a series-shape question rather than a problem with the end-state tree, which looks correct.

---

Generated by Claude Code

[openwrt-ai]

The PKG_MIRROR_HASH fix worked — the package now compiles everywhere. The build failures have moved to the runtime test on the binary installed by this line:

udp-broadcast-relay-redux: [warn] Version check (/usr/sbin/udp-broadcast-relay-redux)
udp-broadcast-relay-redux: First 10 lines of the last output:
  Unknown arg: -?
udp-broadcast-relay-redux: [skip] Version check override
udp-broadcast-relay-redux: No executables in the package provided version 2026.07.26~aa9adef3
udp-broadcast-relay-redux: Generic tests failed

The generic test invokes every packaged executable with version/help flags and expects PKG_VERSION (2026.07.26~aa9adef3) in the output. udp-broadcast-relay-redux has no such flag — it answers Unknown arg: -? — so the probe can never succeed. The failure is byte-identical on x86_64, mips_24kc, aarch64_generic, arm_cortex-a15_neon-vfpv4 and i386_pentium-mmx; the other five targets are green only because they do not run the runtime suite, so this is not arch-specific.

The convention for a package whose executables don't report a version is a test-version.sh beside the Makefile that opts out of the generic probe — see net/uspot/test-version.sh or net/mikrotik-btest/test-version.sh. Since you are re-testing before undrafting, adding net/udp-broadcast-relay-redux/test-version.sh along these lines should clear the remaining five jobs:

#!/bin/sh

# shellcheck shell=busybox

# udp-broadcast-relay-redux does not expose the package version via
# --version or --help. Skip the generic version probe.

case "$PKG_NAME" in
udp-broadcast-relay-redux)
	exit 0
	;;

*)
	echo "Untested package: $PKG_NAME" >&2
	exit 1
	;;
esac

(No suggestion block — this is a new file, not a change to this line.)

---

Generated by Claude Code

[openwrt-ai]

Reviewed the force-pushed series (5 commits) since my last review at 8387db5; no new issues found.

The branch was rebased onto current master and the commits rewritten, but the only change to the package itself since the last reviewed head is the new net/udp-broadcast-relay-redux/test-version.sh — git diff 8387db5..89d5e51 -- 'net/udp-broadcast-relay-redux*' is exactly that one added file. It matches the in-tree convention (#!/bin/sh, # shellcheck shell=busybox, case "$PKG_NAME" with an explicit *) failure arm, mode 0755, no grep -q), and it is folded into 173233c rather than added as a separate fix commit, so the series shape did not grow.

That closed out the last inline finding: all 10 "Feeds Package Test Build" jobs are now green on 89d5e51, including the five that run the runtime suite and previously failed the generic version probe with Unknown arg: -?.

All five commit messages match their diffs — including 173233c, whose seven body bullets each correspond to a hunk (PKG_MAINTAINER, PKG_LICENSE_FILES, GPL-2.0-or-later, TARGET_CPPFLAGS/TARGET_LDFLAGS, $(INSTALL_BIN), description re-indent, test-version.sh) — so no commit checks this round.

One item carries over unchanged: FormalityCheck / OpenWrt Makefiles is still red, now on e174336, for the introduce-then-fix reason raised on the previous three rounds (the revert restores the pre-2019 Makefile without PKG_MAINTAINER/PKG_LICENSE_FILES and with tab-indented description lines; 173233c adds them two commits later, and the check evaluates each commit individually). The two threads about it are marked resolved, so noting it here rather than opening a third: the end-state tree is correct, and this only matters if you want the check green and the not following guidelines label cleared before undrafting.

---

Generated by Claude Code