Accept judge_judging_{start,end}_time hackathon constraints - #266
Merged
Conversation
New per-event HH:MM constraints driving the judging-window copy on the judge application (frontend falls back to 3:00/5:30 PM when unset). Generalizes the judge_venue_arrival_time validation into a shared JUDGE_TIME_CONSTRAINT_KEYS loop in both validate_hackathon_data and validate_hackathon_data_partial. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to frontend PR opportunity-hack/frontend-ohack.dev#341.
The judge application's judging window (previously hardcoded 3:00–5:30 PM) is now per-event admin config. This adds the two new HH:MM constraint keys to hackathon validation, generalizing the existing
judge_venue_arrival_timecheck into a sharedJUDGE_TIME_CONSTRAINT_KEYSloop in bothvalidate_hackathon_dataandvalidate_hackathon_data_partial(invalid values are skipped with a reason on the partial path, same as arrival time).Verified: valid times pass both validators; malformed values raise (full) / skip-and-report (partial).
🤖 Generated with Claude Code