ticket-777: Fix the bug when IMDS fails during auth token refresh whi… - #780
Open
k2chogori wants to merge 1 commit into
Open
ticket-777: Fix the bug when IMDS fails during auth token refresh whi…#780k2chogori wants to merge 1 commit into
k2chogori wants to merge 1 commit into
Conversation
…ch makes followers never reset the state
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #777.
When a token refresh fails before the federation request is made, concurrent callers can remain blocked waiting for the shared in-flight refresh result until the timeout expires.
This change ensures that every leader-side refresh failure:
The refresh logic is extracted into a focused helper while preserving the existing public API and error behavior.
Testing
Added a regression test that simulates a failed refresh of the client certificate before the token request.
Verified that a concurrent caller receives the leader’s failure promptly rather than waiting for the single-flight timeout.
Ran:
Result: 7 tests passed.