Add options --ymin and --ymax for setting vertical scale

[ryanmjacobs]

Fixes #406.

I have been running a similar patch for a few months now. Having the y-axis start at zero is fairly important :) ¹ I have been using the -0 flag pretty much all of the time.

Finally got around to cleaning up my code. I'm not super familiar with Rust, so let me know it there are any changes needed to make the code more idiomatic.

---

• Add options --ymin and --ymax for setting vertical scale
• Option -0 is an alias for --ymin=0
• Ensures at least 1 ms of y-axis when using --ymin=0
  • (Relevant for sub-ms hosts, e.g. gping -0 127.0.0.1)

# gping --help
.
  --ymin <YMIN> Set vertical axis min (ms)
  --ymax <YMAX> Set vertical axis max (ms)
  -0            Equivalent to --ymin=0
.

---

Comparison (before=bottom, after=top) gping -b10 --ymin 0 --ymax 500 3.80.0.0

Footnotes

1. https://xkcd.com/2023/ ↩

[bitwombat]

This is great, thanks @ryanmjacobs . Much much easier to visually gauge how ping is going without the axis jumping all over the place.

Small bug: with --ymin=0 and --ymax=100, the top y-axis label is 94.284 ms, and the value bops around for the first few pings.

gping --ymin=0 --ymax=100 -n 1 -b 300 8.8.8.8

Also, the usage section in readme.md needs to be updated to include your new options.

Great stuff!

[bitwombat]

It's actually more subtle than just not being the right max value.

Set the watch interval really high to make it obvious:

gping --ymin=0 --ymax=100 -n 60 -b 300 8.8.8.8

Notice how the sample is 29.1ms, but shows up below the max value of 27.432ms on the y axis.

[work-apradana]

Hi, this looks great, I want to try this immediately. Can I just clone your branch @ryanmjacobs if this still takes time to be merged?

[ryanmjacobs]

Just saw these! Thanks for the review @bitwombat

It's actually more subtle than just not being the right max value.

Yeah that's a weird bug... I have no idea how the delay time could possibly affect the y-axis, but it clearly does.

---

@work-apradana My systems have been using alias gping="gping -0" for a while now.

Local build should work fine. Just clone my fork and checkout the correct branch.