fix(MainActivity): restore bottom margin after IME hides - #2061
Merged
WhiredPlanck merged 1 commit intoAug 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates MainActivity’s window insets handling so the root view’s bottom margin is correctly restored when the IME (keyboard) hides, while still accounting for system bars.
Changes:
- Capture IME insets alongside system bar insets in the initial
setOnApplyWindowInsetsListener. - Set
binding.root’sbottomMargintomaxOf(systemBars.bottom, ime.bottom)so it reflects whichever inset is larger.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
This is a small patch so I merge it directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes # N/A
Feature
Describe features of this pull request
Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info