fix(os): drop the apt lists after the last apt step; correct the stale comment - #889
Merged
Conversation
…e comment The comment keeping the lists credited the retired Rugix candidate's build-chroot recipes — a reason that left with Rugix. The lists ARE still load-bearing inside this Dockerfile (the toolchain and updater steps install without their own apt-get update), so they survive to the last apt step and are deleted right after it: nothing at runtime uses apt, and the rootfs ships as a flat tarball, so the late deletion leaves every slot and update bundle smaller. Closes #870 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #870
The comment keeping the lists credited the retired Rugix candidate's build-chroot recipes — a reason that left with Rugix, exactly as the issue suspected. But the lists are not simply deletable either: the issue's other prediction was right too. They ARE still load-bearing inside this Dockerfile — the RigForge-toolchain and updater steps run
apt-get installwithout their ownapt-get updateand resolve against the lists from the first step.So the honest shape is both halves: the comment now states the real, checked-by-the-bake reason the lists survive the first layer, and a cleanup after the LAST apt step deletes them — nothing at runtime uses apt, and the rootfs ships as a flat tarball, so the late deletion genuinely leaves every slot and update bundle smaller.
Verified on gouda
os/build-image.sh+mkimage.sh --dev), refuting the "deleting them fails the bake" claim on the shipped path.tests/os/verify-image.sh --test: 69 passed, 0 failed on the built image.apt-get updateon the pinned base); the built image now carries ~0 — ×2 slots plus every bundle.🤖 Generated with Claude Code