Skip to content

security: scope Kaniko builder to PaperTrade namespace #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ty-everett merged 1 commit into from
Aug 31, 2026
Merged

security: scope Kaniko builder to PaperTrade namespace #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions scripts/k8s/build-local-image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ runtime_base_tag="${RUNTIME_BASE_TAG:-node22-bookworm-docs-2026-08-16-r1}"
registry_push="${REGISTRY_PUSH:-10.152.183.28:5000}"
registry_pull="${REGISTRY_PULL:-registry.cars-operator-system.svc.cluster.local:5000}"
kubectl_cmd="${KUBECTL:-kubectl}"
build_namespace="${KUBECTL_BUILD_NAMESPACE:-papertrade-prod}"
kaniko_image="${KANIKO_IMAGE:-gcr.io/kaniko-project/executor:debug}"
build_target="${BUILD_TARGET:-app}"
cache_repo="${KANIKO_CACHE_REPO:-${registry_push}/p2ppsr/papertrade-build-cache}"
Expand All @@ -66,21 +67,21 @@ case "${build_target}" in
esac

cleanup() {
"${kubectl_cmd}" delete pod "${pod}" --ignore-not-found=true --wait=false >/dev/null 2>&1 || true
"${kubectl_cmd}" -n "${build_namespace}" delete pod "${pod}" --ignore-not-found=true --wait=false >/dev/null 2>&1 || true
}
trap cleanup EXIT

printf 'Starting PaperTrade Kaniko builder pod %s\n' "${pod}"
"${kubectl_cmd}" run "${pod}" --restart=Never --image="${kaniko_image}" --command -- sleep 3600
"${kubectl_cmd}" -n "${build_namespace}" run "${pod}" --restart=Never --image="${kaniko_image}" --command -- sleep 3600
for _ in $(seq 1 30); do
if "${kubectl_cmd}" get "pod/${pod}" >/dev/null 2>&1; then
if "${kubectl_cmd}" -n "${build_namespace}" get "pod/${pod}" >/dev/null 2>&1; then
break
fi
sleep 1
done
sleep "${KANIKO_POD_SETTLE_SECONDS:-5}"
"${kubectl_cmd}" wait --for=condition=Ready "pod/${pod}" --timeout=3m
"${kubectl_cmd}" exec "${pod}" -- mkdir -p /kaniko/context
"${kubectl_cmd}" -n "${build_namespace}" wait --for=condition=Ready "pod/${pod}" --timeout=3m
"${kubectl_cmd}" -n "${build_namespace}" exec "${pod}" -- mkdir -p /kaniko/context

COPYFILE_DISABLE=1 tar \
--exclude .git \
Expand All @@ -101,7 +102,7 @@ COPYFILE_DISABLE=1 tar \
--exclude '*.log' \
--exclude '*.tmp' \
--exclude tmp \
-cf - . | "${kubectl_cmd}" exec -i "${pod}" -- tar -xf - -C /kaniko/context
-cf - . | "${kubectl_cmd}" -n "${build_namespace}" exec -i "${pod}" -- tar -xf - -C /kaniko/context

run_kaniko() {
local dockerfile="$1"
Expand All @@ -117,7 +118,7 @@ run_kaniko() {
printf 'Building %s\n' "${destination}"
build_log="$(mktemp)"
set +e
"${kubectl_cmd}" exec "${pod}" -- /kaniko/executor \
"${kubectl_cmd}" -n "${build_namespace}" exec "${pod}" -- /kaniko/executor \
--context=/kaniko/context \
--dockerfile="/kaniko/context/${dockerfile}" \
--destination="${destination}" \
Expand All @@ -137,7 +138,7 @@ run_kaniko() {
return "${kaniko_status}"
fi

last_digest="$("${kubectl_cmd}" exec "${pod}" -- cat "${digest_file}" 2>/dev/null || true)"
last_digest="$("${kubectl_cmd}" -n "${build_namespace}" exec "${pod}" -- cat "${digest_file}" 2>/dev/null || true)"
if [[ -z "${last_digest}" ]]; then
last_digest="$(sed -nE 's/.*Pushed .*@(sha256:[0-9a-f]{64}).*/\1/p' "${build_log}" | tail -1)"
fi
Expand Down