fix: Fix some issues with StringUtilBenchmark - #229
Open
dwalluck wants to merge 2 commits into
Open
Conversation
* Make `Random` static even though in practice it should only be created once already (fixes SpotBugs warning) * Initialize fields to empty to prevent warning "`@NullMarked` fields must be initialized" * Iterate over `decodedData` directly instead of using the `DATA_COUNT` constant even though in practice these should always have the same length * Fill data fields directly instead of using a local variables/parameters with the same names
dwalluck
force-pushed
the
string-util-benchmark
branch
from
April 2, 2025 15:28
de755c4 to
7bfb05b
Compare
ppkarwasz
reviewed
Apr 3, 2025
There was a problem hiding this comment.
Pull request overview
This PR adjusts the JMH StringUtilBenchmark setup to address static-analysis warnings and make benchmark data generation/usage less error-prone.
Changes:
- Make the RNG a single shared instance and initialize benchmark arrays to empty to satisfy nullness/static-analysis checks.
- Consolidate benchmark data generation/encoding into a single
createData()method and avoid unnecessary local shadowing. - Update
baseline()to iterate overdecodedDatadirectly.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
73
to
76
| @Setup | ||
| public void setup() { | ||
| decodedData = createDecodedData(); | ||
| encodedData = encodeData(decodedData); | ||
| createData(); | ||
| } |
Comment on lines
104
to
108
| @Benchmark | ||
| public void baseline(Blackhole blackhole) { | ||
| for (int i = 0; i < DATA_COUNT; i++) { | ||
| byte[] buffer = decodedData[i].getBytes(StandardCharsets.UTF_8); | ||
| for (String decodedStr : decodedData) { | ||
| byte[] buffer = decodedStr.getBytes(StandardCharsets.UTF_8); | ||
| // Prevent JIT compiler from assuming the buffer was not modified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Randomstatic even though in practice it should only be created once already (fixes SpotBugs warning)@NullMarkedfields must be initialized"decodedDatadirectly instead of using theDATA_COUNTconstant even though in practice these should always have the same length