feat: Add tid/sid validation to system save update endpoint - #83
Open
SirzBenjie wants to merge 3 commits into
Open
feat: Add tid/sid validation to system save update endpoint#83SirzBenjie wants to merge 3 commits into
SirzBenjie wants to merge 3 commits into
Conversation
DayKev
reviewed
Aug 13, 2026
DayKev
approved these changes
Aug 13, 2026
DayKev
left a comment
DayKev
left a comment
Contributor
There was a problem hiding this comment.
Basic testing shows everything working.
- A valid save could be loaded and updated without issues
- A save with re-applied system migrators was blocked from uploading
- A save from an older version was blocked from uploading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tid/sid validation to the system save endpoint as it is done in the updateAll endpoint.
This addresses an issue that would allow a malformed or modified save to send a save with a tid/sid that didn't match the database record, preventing the user from saving any data.
As part of this change, extracted out logic shared between the
updateAllmethod and theupdatecase block in thehandleSystemmethod for DRYness.