Skip to content

Esmith solution - #12

Open
Stellara wants to merge 3 commits into
masterfrom
esmith_solution
Open

Esmith solution#12
Stellara wants to merge 3 commits into
masterfrom
esmith_solution

Conversation

@Stellara

@Stellara Stellara commented Jun 3, 2015

Copy link
Copy Markdown

@jaybobo

Works in browser, but it's not my favorite way to implement this.

My issues:

  • I wish it were more object-oriented.
  • I haven't touched Prototypes in months and months. (Will use them on the RapGenerator challenge).
  • Attempts to DRY it up failed because I am too much in "Ruby land" still. For instance, JS has no string interpolation to speak of, so that made my attempts to abstract fail utterly.
  • Called it a day on this solution in favor of time-boxing.

Comment thread validator.js

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! My suggestion would be to pull the function definitions for ValidateForm and all of the method's it calls outside of the document ready callback.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally makes sense! Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants