Build GUFI on macOS, test the Studio there, and correct the README - #335
Merged
Merged
Conversation
The README said GUFI does not build on macOS. It does: upstream runs a macOS job in its own CI with the AI dependencies enabled, and the difficulty is not the platform but the toolchain, since libomp is not wired into Apple's clang and the build scripts expect GNU utilities. setup_gufi.sh now handles macOS the way that CI does, with Homebrew's LLVM, libomp, and GNU tools placed ahead on PATH for the build only. It also takes GUFI_AI=0 for a quick build without sqlite-vec and sqlite-lembed, which is the hard part: that build keeps metadata, filename, and full-text search and loses only the semantic blend. On a prefix the user owns it installs without sudo, which is the laptop case. CI gains a macOS job that builds and runs the suite there. It does not build GUFI, which takes far longer than the tests and has its own upstream coverage; what it catches is a Linux-only assumption in the server or a tool that exists only under apt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README said GUFI does not build on macOS. It does: upstream runs a
macos-15job in its own CI with-DDEP_AI=On, and the difficulty is the toolchain rather than the platform, since libomp is not wired into Apple's clang and GUFI's scripts expect GNU utilities.indexer/setup_gufi.shnow handles macOS the way that CI does: Homebrew's LLVM asCC/CXX, libomp passed through the OpenMP variables, and coreutils/findutils/gnu-sed/grep/diffutils placed ahead onPATHfor the build only. It also acceptsGUFI_AI=0, which skipssqlite-vecandsqlite-lembed(the hard part, since lembed carries llama.cpp) for a fast build that keeps metadata, filename, and full-text search and loses only the semantic blend.DEP_AIdefaults to On upstream, so a plaincmakeattempts them; this makes the choice explicit. Installing to a prefix the user owns no longer calls sudo.CI gains a macOS job that installs Node, pnpm, tesseract and poppler, then builds and runs the suite. It deliberately does not build GUFI: that takes far longer than the tests and has upstream coverage. What this job catches is a Linux-only assumption in the server or a tool that only exists under apt. The repo is public, so macOS runner time is free.
README now describes both build paths instead of claiming the platform is unsupported.