Remove the scribe package - #2
Open
tjcouch-sil wants to merge 1 commit into
Open
Conversation
Nothing in Platform.Bible consumes @eten-tech-foundation/scribe-editor, and this repo's CLAUDE.md already described the package as not currently maintained and told readers not to use it as a reference. Carrying it means building, typechecking, and testing a package no consumer depends on. Kept as its own commit so the diff against eten-tech-foundation/scripture-editors stays easy to reason about — the rest of the adoption changes touch documentation and workflows, this one touches code. Removes packages/scribe and the wiring it left behind: the tsconfig project reference, the eslint ignore entry, the README demo/package table rows and their npm badges, the mermaid graph nodes, the CLAUDE.md guidance bullet, and the pnpm-lock workspace entry. Also drops scribe's NoteEditor as the worked example in libs/shared's usjBaseNodes comment; the point that comment makes — a non-react host registers the class straight from usjBaseNodes — still stands without it. The history is untouched: scribe's commits and its scribe_v* release tags are still here. Verified with build, typecheck, and test across the remaining nine projects, run in that order (running typecheck before build fails on unmodified main too — TS project references need the declarations built first).
tjcouch-sil
added a commit
that referenced
this pull request
Sep 3, 2026
`homepage`, `repository`, and `bugs` still named eten-tech-foundation, so everything npm derives from them — the repository link on npmjs.com, `npm repo`, and the "report an issue" link — sent people to the repository this one replaces. The package names and their `@eten-tech-foundation` scope are deliberately unchanged: publishing continues under that scope, and renaming would break every consumer. Only the location of the source moves. `packages/scribe` is left alone; #2 removes that package. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017jvJ2eYTfxJaBkKoQbVeiW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
packages/scribeand the wiring it left behind.Part of PT-4500.
Why
Nothing in Platform.Bible consumes
@eten-tech-foundation/scribe-editor. This repo's ownCLAUDE.mdalready described the package as "Not currently maintained — do NOT use it as a reference for existing patterns or conventions". Carrying it means building, typechecking, and testing a package no consumer depends on.Kept as its own PR so the diff against
eten-tech-foundation/scripture-editorsstays easy to reason about: the adoption PR (#1) touches documentation and workflows, this one touches code.What goes
packages/scribe/tsconfig.jsonproject reference,eslint.config.mjsignore entryCLAUDE.mdguidance bulletpnpm-lock.yamlworkspace entry (lockfile regenerated)One code comment changes:
libs/shared/src/nodes/usj/index.tsused scribe'sNoteEditoras its worked example of a non-react host. The point it makes — that a non-react host builds straight fromusjBaseNodes, so every USJ-shaped editor needsAttributeRunNoderegistered — still stands without the example.History is untouched. Scribe's commits and its 8
scribe_v*release tags are still in this repo; only the working tree loses the directory.Verification
build,typecheck, andtestacross the remaining nine projects — all clean.Worth knowing for anyone validating this: running
typecheckbeforebuildfails on unmodifiedmaintoo, with TS6305 "output file has not been built from source file". TS project references need declarations built first, which is why CI runs them as separate sequential steps. I caught myself on this and re-ran a cold control onmainto confirm it was not caused by this change.Merge order
Merge after #1. That PR removes the scribe publish workflow and the tag-triggered publish steps that reference
packages/scribe; merging this one first would briefly leave workflows pointing at a directory that no longer exists.🤖 Generated with Claude Code
https://claude.ai/code/session_01VCWPCf35QD5sTkFghsTfUX
This change is