ci: bound how long every job may run - #761
Merged
Merged
Conversation
Fourteen of eighteen jobs set no timeout, so GitHub's six-hour default applied. A job that hangs rather than fails is the worst case: it reads as slowness, it holds the pull request, and nobody gets a signal until the day is gone. The rust job did exactly that today, sitting in post-job cleanup with every real step already green. Budgets come from the worst duration over six successful runs on the default branch, with headroom for a cold cache. Rust peaks at fourteen minutes and gets forty-five; nothing else exceeds five and gets ten, except the uniffi bindings at fifteen. These are a backstop for a hung runner, not a performance target. A job that starts legitimately approaching its budget wants the budget raised.
github-actions
Bot
added
the
github_actions
|
CI Status: 17 required jobs green, 15 passed and 2 skipped by path filter. All job results
Commit |
TarikGul
marked this pull request as ready for review
September 14, 2026 16:00
Imod7
approved these changes
Sep 14, 2026
Forty five was too generous. Over twenty five successful runs the job sits at a p50 of 7.5 minutes with a maximum of 14.4, so thirty is a little over twice the worst case while cutting the dead time a hang can waste by a third.
filvecchiato
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourteen of eighteen jobs in
ci.ymlset notimeout-minutes, so GitHub'ssix-hour default applied.
That is not theoretical. The
rustjob hung today on #741, wedged in post-jobcleanup with
cargo build,test, three clippy passes andfmt --checkallalready green. It sat for 59 minutes before being cancelled by hand, and would
have held the pull request until 18:38. A hung job is worse than a failing one:
it reads as slowness, so nobody investigates.
Budgets are measured, not guessed, taken from the worst duration over six
successful runs on
main:rustios-bindingsios-swift,android-bindings,e2eandworkflow-lintalready had oneand are untouched.
These are a backstop against a hung runner, not a performance target. A job
legitimately approaching its budget wants the budget raised rather than the job
hurried.