sorting bug fix - #326
Merged
Merged
Conversation
M-Lampert
approved these changes
Jul 28, 2026
M-Lampert
left a comment
M-Lampert
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for catching this. Feel free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turned up randomly during other work and has to do with:
The second return value is
Noneif the edge index is already sorted, and we end up inadvertently adding a dimension if that's the case. This bug fix should fix it.The first commit adds a failing test, and the next fixes the code and removes the xfail.