feat(progress): add pf-progress - #2511
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: d610761 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
work in progress
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
brianferry
marked this pull request as ready for review
June 7, 2023 13:20
brianferry
added
ready: code review
Closed
bennypowers
reviewed
Jun 20, 2023
bennypowers
reviewed
Jun 20, 2023
bennypowers
reviewed
Jun 20, 2023
bennypowers
reviewed
Jun 20, 2023
bennypowers
requested changes
Jun 20, 2023
bennypowers
left a comment
bennypowers
left a comment
Member
There was a problem hiding this comment.
most pressing change is to put remove the private updateAccessibility method and put that stuff in the template instead
it might we good to set a private property in willUpdate for that purpose
bennypowers
approved these changes
Aug 9, 2023
bennypowers
left a comment
bennypowers
left a comment
Member
There was a problem hiding this comment.
LGTM
@brianferry @eyevana please validate the changes to the test files
Collaborator
Author
|
Tooltip and progress look good to me 👍🏼 |
eyevana
reviewed
Aug 9, 2023
eyevana
reviewed
Aug 10, 2023
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bennypowers
enabled auto-merge (squash)
August 21, 2023 12:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pf-progress
Implemented Patternfly's Progress as web component.
Related issues
(#2508)
Preview
Link(s) to demo page(s) where this element can be viewed:
Link