Skip to content

docs: improve hamburger menu for mobile - #2552

Merged
zeroedin merged 3 commits into
mainfrom
docs/hamburger-menu
Jul 12, 2023
Merged

docs: improve hamburger menu for mobile#2552
zeroedin merged 3 commits into
mainfrom
docs/hamburger-menu

Conversation

@zeroedin

@zeroedin zeroedin commented Jul 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What I did

  1. Fixed z-index for menu toggle button
  2. Added small icon logo when < 420px wide screen
  3. Improved spacing around logo and toggle

Closes #2551

Testing Instructions

  1. View deploy preview

Notes to Reviewers

  1. Hamburger buttons should now be visible and clickable.

@zeroedin zeroedin added docs Documentation updates bug labels Jul 12, 2023
@zeroedin zeroedin added this to the PatternFly Elements 2.x milestone Jul 12, 2023
@zeroedin zeroedin self-assigned this Jul 12, 2023
@changeset-bot

changeset-bot Bot commented Jul 12, 2023 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 26e60cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added doc AT passed Automated testing has passed labels Jul 12, 2023
@github-actions

github-actions Bot commented Jul 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 953bf3a
😎 Deploy Preview https://deploy-preview-2552--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@zeroedin zeroedin changed the title docs: set z-index so menu button is above header-bar docs: improve hamburger menu for mobile Jul 12, 2023
@zeroedin
zeroedin requested a review from nikkimk July 12, 2023 18:57
nikkimk
nikkimk approved these changes Jul 12, 2023
View reviewed changes

@nikkimk nikkimk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zeroedin
zeroedin merged commit c7fa944 into main Jul 12, 2023
@zeroedin
zeroedin deleted the docs/hamburger-menu branch July 12, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nikkimk nikkimk nikkimk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@zeroedin zeroedin

Labels

AT passed Automated testing has passed bug docs Documentation updates ready to merge

Projects

None yet

Milestone

PatternFly Elements 2.x

Development

Successfully merging this pull request may close these issues.

[docs]: hamburger menu is missing - regression

2 participants

@zeroedin @nikkimk