feat(button)!: port to <pf-v6-button> - #3157
Open
ArathyKumar wants to merge 13 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 72754ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat(button)!: port to `<pf-v6-button>`"
} |
Contributor
Prevent Chromium Tab-wrap flakiness with a trailing focus sentinel, stop RovingTabindexController from stealing focus after Tab-out, pin timestamp fixtures to en-US, and add the missing major changeset for the v5→v6 button port. Assisted-By: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
zeroedin
changed the title
<pf-v6-button>
Contributor
Contributor
…check Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # elements/pf-v5-clipboard-copy/pf-v5-clipboard-copy.ts # elements/pf-v5-tooltip/demo/block-triggers.html # elements/pf-v5-tooltip/demo/flip.html # elements/pf-v5-tooltip/demo/performance.html # elements/pf-v5-tooltip/demo/trigger.html # elements/pf-v5-tooltip/docs/pf-v5-tooltip.md
Contributor
Contributor
Contributor
Contributor
This comment has been minimized.
This comment has been minimized.
ArathyKumar
marked this pull request as ready for review
August 24, 2026 14:19
Collaborator
|
@ArathyKumar, Since we don't hvae Qodo enabled for this repo: have you had an agent review this PR yet? I had Grok review it in the Qodo style. This feedback will need to be vetted. Results below: AI review resultsCode Review 🐞 Bugs (3) 1.
|
Collaborator
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
Collaborator
|
@coderabbitai full review |
|
|
Important Review skippedToo many files! This PR contains 123 files, which is 23 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (123)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Ported the existing pf-v5-button Web Component to a new pf-v6-button Web Component that follows design and provides feature parity with the PatternFly v6 Button React component.
Changes
Testing Instructions
Notes to Reviewers
This PR ports the existing pf-v5-button Web Component to pf-v6-button and brings it in line with the PatternFly v6 React Button.
For more details about the requirements and expected behavior, please refer to the related issue #2984.