Skip DuckDB parity checks when the extra is not installed - #7
Closed
pavanamthomas wants to merge 1 commit into
Closed
Skip DuckDB parity checks when the extra is not installed#7pavanamthomas wants to merge 1 commit into
pavanamthomas wants to merge 1 commit into
Conversation
The README install line uses `.[duckdb]`, and CI does too. A plain `pip install -e .` was failing three parity tests on ImportError. SQLite versus Pandas still runs; the DuckDB comparisons skip unless the extra is there. Co-authored-by: Dr. Pavanam Thomas <pavanamthomas@users.noreply.github.com>
pavanamthomas
marked this pull request as ready for review
August 28, 2026 11:51
Owner
Author
|
Landed on main as a regular commit. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip install -e .followed bypytestwas failing three tests withinstall sqlfeat[duckdb]. The point-in-time claim does not need DuckDB: SQLite versus the independent Pandas calculation still runs, and the planted99999.0is excluded on that path.The DuckDB comparisons skip unless the extra is installed. CI still installs
.[duckdb]and runs the full set.Verified locally: two skips without DuckDB, six passing with it, full suite green after
.[duckdb].