Conversation
Every query schema called report(\$exception) whenever a query attempt failed, which fires on any restart, boot-up window, or brief network hiccup - not just genuine bugs. With the players widget polling every 30s, this spammed the log on something completely routine: the queried server (or proxy) not answering yet. The UI already reflects an unreachable server as offline/unknown without needing a log entry for it. Drop the report() calls in all six query schemas (Java query+ping, Bedrock, Source/GoldSource, CitizenFX, Palworld); the proxy schema inherits the Java ones, so this covers it too. The exceptions are still caught and swallowed exactly as before, just without logging. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SA9aNschKoWLmWkWNC2fGZ
Contributor
|
Warning Review limit reachedNext included review available in 10 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every query schema called
report($exception)whenever a query attempt failed - which happens on every server restart, boot-up window, or brief network hiccup, not just genuine bugs. With the players widget polling every 30s, this spammed the log for something completely routine. The UI already reflects an unreachable server as offline/unknown without needing a log entry for it.Drops the
report()calls in all query schemas (Java query+ping, Bedrock, Source/GoldSource, CitizenFX, Palworld). Exceptions are still caught and swallowed exactly as before, just without logging.