feat(common-components): add notifications as an Angular 22 compatible alternative for ngx-toastr - #149
Open
glenstaes wants to merge 3 commits into
Open
feat(common-components): add notifications as an Angular 22 compatible alternative for ngx-toastr#149glenstaes wants to merge 3 commits into
glenstaes wants to merge 3 commits into
Conversation
MarkCuypersPpw
requested changes
Aug 19, 2026
| display: flex; | ||
| flex-direction: column; | ||
| border-radius: var(--ppw-ds-radius-small); | ||
| width: 472px; |
Contributor
There was a problem hiding this comment.
Waarom deze hard-coded values?
Member
Author
There was a problem hiding this comment.
Zodat notificaties ook weer niet de volledige breedte gaan innemen van de pagina. Een ander voorstel?
Contributor
There was a problem hiding this comment.
iets met een minmax functie en een 'vw' value ofzo?
Member
Author
There was a problem hiding this comment.
zal eens iets proberen :)
| * ``` | ||
| */ | ||
| @Component({ | ||
| selector: 'sw-notification', |
Contributor
There was a problem hiding this comment.
vanwaar komt die sw- prefix? Dat moet toch ppw- zijn?
Member
Author
There was a problem hiding this comment.
Dat krijg je wanneer je dat component kopieert uit een project naar de SDK en dan vergeet de selector aan te passen 😆
glenstaes
force-pushed
the
feature/notifications
branch
from
August 19, 2026 08:18
9ab9f9d to
5dd1005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This component leverages the new design system tokens, so there's already a hard requirement on that.
